Skip to content

#272 - resolve_references is False by default #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

#272 - resolve_references is False by default #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/minos-microservice-cqrs/minos/cqrs/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class PreEventHandler:
"""Pre Event Handler class."""

@classmethod
async def handle(cls, diff: T, resolve_references: bool = True, **kwargs) -> T:
async def handle(cls, diff: T, resolve_references: bool = False, **kwargs) -> T:
"""Handle Ref resolution for Events.

:param diff: The instance containing ``Ref`` instances.
Expand Down
19 changes: 6 additions & 13 deletions packages/core/minos-microservice-cqrs/tests/test_cqrs/test_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def setUp(self) -> None:
FieldDiffContainer([FieldDiff("bars", list[Ref[Bar]], [b.uuid for b in self.bars])]),
)

async def test_handle(self):
async def test_handle_resolving_dependencies(self):
value = Event(
self.uuid,
"Foo",
Expand All @@ -49,29 +49,22 @@ async def test_handle(self):
)

with patch("minos.aggregate.RefResolver.resolve", return_value=value):
observed = await PreEventHandler.handle(self.diff)
observed = await PreEventHandler.handle(self.diff, resolve_references=True)

expected = Event(
self.uuid,
"Foo",
1,
Action.CREATE,
self.now,
FieldDiffContainer([FieldDiff("bars", list[Ref[Bar]], self.bars)]),
)
self.assertEqual(expected, observed)
self.assertEqual(value, observed)
self.assertEqual(self.bars, [b.data for b in observed["bars"]])

async def test_handle_not_aggregate_diff(self):
observed = await PreEventHandler.handle(56)
self.assertEqual(56, observed)

async def test_handle_without_resolving_references(self):
observed = await PreEventHandler.handle(self.diff, resolve_references=False)
observed = await PreEventHandler.handle(self.diff)
self.assertEqual(self.diff, observed)

async def test_handle_raises(self):
with patch("minos.aggregate.RefResolver.resolve", side_effect=ValueError):
observed = await PreEventHandler.handle(self.diff)
observed = await PreEventHandler.handle(self.diff, resolve_references=True)

expected = Event(
self.uuid,
Expand Down