Skip to content

#150 - Add ConfigV2 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 24, 2022
Merged

#150 - Add ConfigV2 #305

merged 23 commits into from
Mar 24, 2022

Conversation

@garciparedes
Copy link
Member

@garciparedes garciparedes commented Mar 21, 2022

No description provided.

Sergio García Prado added 3 commits March 21, 2022 17:12
ISSUE #150
f07e735 
* Add skeleton of `ConfigV2`.
Merge remote-tracking branch 'origin/issue-150-versionate-config' int…
fceb0e7 
…o issue-150-config-v2
ISSUE #150
b8149ba 
* Add version.
@garciparedes garciparedes added enhancement New feature or request config labels Mar 21, 2022
@garciparedes garciparedes added this to the v0.6.x milestone Mar 21, 2022
@garciparedes garciparedes self-assigned this Mar 21, 2022
@garciparedes garciparedes changed the base branch from main to issue-150-versionate-config March 21, 2022 16:26
Sergio García Prado added 3 commits March 22, 2022 08:46
Merge remote-tracking branch 'origin/issue-150-versionate-config' int…
9161e12 
…o issue-150-config-v2
ISSUE #150
3745cf2 
* Improve how config file path is set on tests.
ISSUE #150
3f29554 
* Be compatible with latest `Config` interface.
@garciparedes garciparedes marked this pull request as draft March 22, 2022 07:59
Sergio García Prado added 9 commits March 22, 2022 09:22
Merge remote-tracking branch 'origin/issue-150-versionate-config' int…
fa6e856 
…o issue-150-config-v2
ISSUE #150
fbc55b1 
* Add `v2.yml`.
ISSUE #150
02c2868 
* Add tests structure.
ISSUE #150
a485d2d 
* Improve tests.
ISSUE #150
0251654 
* Fix path typo.
ISSUE #150
91cabea 
* Minor improvement.
ISSUE #150
560000e 
* Working on `ConfigV2`.
ISSUE #150
205c3f9 
* Add `BuildableMixin`.
ISSUE #150
30bc58b 
* Now `InjectableMixin` inherit from `SetupMixin`.
@garciparedes garciparedes linked an issue Mar 22, 2022 that may be closed by this pull request
Refactor the configuration file and Config object #150
Closed
Sergio García Prado added 4 commits March 22, 2022 13:17
Merge remote-tracking branch 'origin/issue-150-versionate-config' int…
234475c 
…o issue-150-config-v2
ISSUE #150
2b32262 
* Minor improvements.
ISSUE #150
557e81f 
* Increase coverage.
ISSUE #150
b478b56 
* Add missing docstring.
@garciparedes garciparedes requested a review from a team March 23, 2022 11:18
@garciparedes garciparedes marked this pull request as ready for review March 23, 2022 11:18
ISSUE #150
b929040 
* Add support for environment and parameterized variables.
Base automatically changed from issue-150-versionate-config to 0.6.0 March 23, 2022 12:22
albamig
albamig approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@albamig albamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine!

@garciparedes
Copy link
Member Author

garciparedes commented Mar 24, 2022

Thanks @albamig!

@garciparedes garciparedes merged commit 587098f into 0.6.0 Mar 24, 2022
@garciparedes garciparedes deleted the issue-150-config-v2 branch March 24, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@albamig albamig albamig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@garciparedes garciparedes

Labels

config enhancement New feature or request versioning

Projects

None yet

Milestone

v0.6.x

Development

Successfully merging this pull request may close these issues.

Refactor the configuration file and Config object

3 participants

@garciparedes @albamig