chore(deps): bump outdated dependencies to latest#122
Conversation
- @ai-sdk-tool/parser 4.1.20 → 4.1.21
- vitest 4.1.4 → 4.1.5
- @mariozechner/pi-tui 0.57.1 / 0.68.0 → 0.68.1
Realign @ai-sdk-tool/tui peer range for @mariozechner/pi-tui to ^0.68.1
and adapt createAliasAwareAutocompleteProvider to the async autocomplete
API introduced in pi-tui 0.68 (getSuggestions now returns a Promise and
accepts a { signal, force? } options argument).
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including @ai-sdk-tool/parser, vitest, and @mariozechner/pi-tui, and refactors the autocomplete logic in @ai-sdk-tool/tui to support a new asynchronous API. The review feedback suggests enhancing the implementation by importing AutocompleteOptions and ensuring that the options parameter, which includes the cancellation signal, is correctly propagated through getAliasArgumentSuggestions and down to the underlying command completions.
| import { | ||
| type AutocompleteItem, | ||
| type AutocompleteProvider, | ||
| type AutocompleteSuggestions, |
There was a problem hiding this comment.
To fully support the new async autocomplete API, you should also import AutocompleteOptions from @mariozechner/pi-tui. This type contains the signal (AbortSignal) and force flag used for cancellation and cache-busting.
| type AutocompleteSuggestions, | |
| type AutocompleteSuggestions, | |
| type AutocompleteOptions, |
| export const getAliasArgumentSuggestions = async ( | ||
| textBeforeCursor: string, | ||
| commandSuggestionsByName: Map<string, SlashCommand> | ||
| ): { items: AutocompleteItem[]; prefix: string } | null => { | ||
| ): Promise<{ items: AutocompleteItem[]; prefix: string } | null> => { |
There was a problem hiding this comment.
The getAliasArgumentSuggestions function should be updated to accept the options parameter. This allows forwarding the AbortSignal to the underlying command completions. Additionally, you can use the AutocompleteSuggestions type for the return value for better clarity.
| export const getAliasArgumentSuggestions = async ( | |
| textBeforeCursor: string, | |
| commandSuggestionsByName: Map<string, SlashCommand> | |
| ): { items: AutocompleteItem[]; prefix: string } | null => { | |
| ): Promise<{ items: AutocompleteItem[]; prefix: string } | null> => { | |
| export const getAliasArgumentSuggestions = async ( | |
| textBeforeCursor: string, | |
| commandSuggestionsByName: Map<string, SlashCommand>, | |
| options?: AutocompleteOptions | |
| ): Promise<AutocompleteSuggestions | null> => { |
|
|
||
| const argumentPrefix = textBeforeCursor.slice(spaceIndex + 1); | ||
| const items = command.getArgumentCompletions(argumentPrefix); | ||
| const items = await command.getArgumentCompletions(argumentPrefix); |
There was a problem hiding this comment.
Forward the options (which includes the signal) to getArgumentCompletions. This ensures that if the user continues typing and a new autocomplete request is triggered, the previous async operation can be properly aborted.
| const items = await command.getArgumentCompletions(argumentPrefix); | |
| const items = await command.getArgumentCompletions(argumentPrefix, options); |
| const aliasArgumentSuggestions = await getAliasArgumentSuggestions( | ||
| textBeforeCursor, | ||
| commandSuggestionsByName | ||
| ); |
There was a problem hiding this comment.
Pass the options received in getSuggestions down to getAliasArgumentSuggestions so that the cancellation signal is correctly propagated.
const aliasArgumentSuggestions = await getAliasArgumentSuggestions(
textBeforeCursor,
commandSuggestionsByName,
options
);![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
1 participant
Summary
pnpm outdated -ris now clean).@ai-sdk-tool/tui's@mariozechner/pi-tuipeer range to^0.68.1and adaptcreateAliasAwareAutocompleteProviderto the async autocomplete API introduced in pi-tui 0.68.patchchangeset covering@ai-sdk-tool/tui,@plugsuits/minimal-agent, andplugsuits.Version bumps
@ai-sdk-tool/parser^4.1.20^4.1.21plugsuitsvitest(dev)^4.1.4^4.1.5@plugsuits/minimal-agent@mariozechner/pi-tui^0.57.1/^0.68.0^0.68.1@plugsuits/minimal-agent,plugsuits,@ai-sdk-tool/tui(peer)Breaking API adapted (pi-tui 0.57 → 0.68)
AutocompleteProvider.getSuggestionsis nowasyncand takes a 4th{ signal, force? }options argument.SlashCommand.getArgumentCompletionsis alsoAwaitable<...>.packages/tui/src/autocomplete.tswas updated to match:createAliasAwareAutocompleteProvidernow returns an async provider that forwards thesignal/forceoptions to the underlyingCombinedAutocompleteProvider.getAliasArgumentSuggestionsisasyncand awaitsgetArgumentCompletions.Verification
pnpm run build— all 6 packages buildpnpm run typecheck— clean across all packagespnpm run test— 65 tests / 3 files pass (headless); 9/9 turbo tasks successfulpnpm exec ultracite check .— cleanpackages/cea:Summary by cubic
Update outdated deps and switch
@ai-sdk-tool/tuito the async autocomplete API in@mariozechner/pi-tui0.68.1. Consumers of@ai-sdk-tool/tuinow need@mariozechner/pi-tui@^0.68.1.Dependencies
@ai-sdk-tool/parser→^4.1.21vitest→^4.1.5@mariozechner/pi-tui→^0.68.1(align@ai-sdk-tool/tuipeer to^0.68.1)Refactors
createAliasAwareAutocompleteProviderasync; forward{ signal, force? }toCombinedAutocompleteProvider.getAliasArgumentSuggestionsasync and awaitSlashCommand.getArgumentCompletions.Written for commit 6dfca47. Summary will update on new commits.