Skip to content

Trezor firmware versioning#1950

Merged
ImplOfAnImpl merged 4 commits intomasterfrom
trezor_firmware_versioning
Aug 12, 2025
Merged

Trezor firmware versioning#1950
ImplOfAnImpl merged 4 commits intomasterfrom
trezor_firmware_versioning

Conversation

@ImplOfAnImpl
Copy link
Copy Markdown
Contributor

@ImplOfAnImpl ImplOfAnImpl commented Aug 7, 2025

  • The wallets now obtain the Trezor firmware version and refuse to continue if its major component doesn't match the expected value.
    Node-gui displays the firmware version in its status bar; for wallet-cli, it is printed by wallet-info.

  • A couple minor issues were fixed:

    • node-gui didn't handle multiple connected devices well, producing an obscure error like "No wallet opened". Now it prints a meaningful error at least, suggesting to leave only one device connected and retry;
    • wallet-cli's Trezor device selection was broken, failing with the "File already exists" error, because we didn't delete the temporarily created wallet file if MultipleAvailableTrezorDevices was being returned (in create_wallet we were deleting it only on error and in recover_wallet we weren't deleting it at all).
  • A Trezor-specific readme file was added with some security-related caveats and build instructions.

  • Minor cleanup of existing readme files.

@ImplOfAnImpl ImplOfAnImpl force-pushed the trezor_firmware_versioning branch from 834ae9e to 7e90cdf Compare August 7, 2025 18:57
@ImplOfAnImpl ImplOfAnImpl force-pushed the trezor_firmware_versioning branch from 7e90cdf to 3bccead Compare August 11, 2025 10:26
@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review August 11, 2025 11:29
@ImplOfAnImpl ImplOfAnImpl merged commit 145f79e into master Aug 12, 2025
28 checks passed
@ImplOfAnImpl ImplOfAnImpl deleted the trezor_firmware_versioning branch August 12, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants