Conversation
ImplOfAnImpl
force-pushed
the
minor_cleanup
branch
from
4310935 to
03f9952
Compare
ImplOfAnImpl
force-pushed
the
minor_improvements
branch
from
69fdefb to
f561724
Compare
OBorce
approved these changes
Feb 20, 2026
ImplOfAnImpl
force-pushed
the
minor_improvements
branch
from
9f32e9b to
347cd2e
Compare
…nt; avoid showing mode selection dialog in node-gui if `--clean-data` was specified; do the cleanup after logging was initialized, so that the corresponding log lines are visible.
ImplOfAnImpl
force-pushed
the
minor_improvements
branch
from
347cd2e to
6a32ca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of minor improvements extracted from my other branch:
When
--clean-datais passed tonode-gui, don't show the wallet mode (i.e. hot vs cold) selection dialog, because it makes no sense in this case.Improve spinner widget shown in the
GuiState::Loadingstate - previously it was just a dot flying near the edges of the window, almost invisible.Note that at this moment we show the spinner only for a brief moment, so the improvements isn't really noticeable
(initially I made the change for the
--import-bootstrap-fileoption, but later I decided to remove the option from node-gui, so this improvement is mostly useless for now).Subsystems can now receive the "shutdown initiated" flag, which can be used to cancel long-running blocking tasks (used during bootstrapping in a later PR).
I did some cleanup in the functional test framework removing useless things like "bitcoin.conf".
ChainstateEvent::NewTipis now also sent after block invalidation or resetting block failure flags, if it resulted in a reorg.