Skip to content

Rand upgrade: autoreplace "gen" with "random" etc#2041

Merged
ImplOfAnImpl merged 14 commits intomasterfrom
rand_upgrade_autorename_gen_to_random
Apr 24, 2026
Merged

Rand upgrade: autoreplace "gen" with "random" etc#2041
ImplOfAnImpl merged 14 commits intomasterfrom
rand_upgrade_autorename_gen_to_random

Conversation

@ImplOfAnImpl
Copy link
Copy Markdown
Contributor

@ImplOfAnImpl ImplOfAnImpl commented Apr 20, 2026

Here I auto-replace gen and r#gen with random, gen_bool with random_bool and gen_range with random_range.

The purpose of this PR is to make #2042 smaller. The code here doesn't compile. Once both PRs are approved I'll merge #2042 into this one and then this one to master.

P.S. very few occurrences of "rand" and friends were actually meant to retain their original names, because they are called on a 0.8 RNG. I kept these redundant changes in this PR and reverted them in #2042.

@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review April 20, 2026 20:14
@ImplOfAnImpl ImplOfAnImpl force-pushed the rand_upgrade_autorename_gen_to_random branch from 2e45c58 to c9f47dd Compare April 23, 2026 10:20
@ImplOfAnImpl ImplOfAnImpl force-pushed the rand_upgrade_autorename_gen_to_random branch from d139600 to 252725e Compare April 23, 2026 18:27
@ImplOfAnImpl
Copy link
Copy Markdown
Contributor Author

ImplOfAnImpl commented Apr 23, 2026

I had to push an additional commit after the merge from #2042, fixing an unrelated typo. This is just to trigger the CI again, which got stuck for some reason (adding a commit and then dropping it didn't help).
The problem was in branch protection rules. I removed the extra commit.

@ImplOfAnImpl ImplOfAnImpl force-pushed the rand_upgrade_autorename_gen_to_random branch from 32132b0 to 02c4acb Compare April 24, 2026 08:57
@ImplOfAnImpl ImplOfAnImpl force-pushed the rand_upgrade_autorename_gen_to_random branch from 02c4acb to d9e13ce Compare April 24, 2026 10:12
@ImplOfAnImpl ImplOfAnImpl merged commit b6ee897 into master Apr 24, 2026
20 checks passed
@ImplOfAnImpl ImplOfAnImpl deleted the rand_upgrade_autorename_gen_to_random branch April 24, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants