Fix for --exclude-pattern regression #167
Conversation
This commit fixes a regression in the `--exclude-pattern` flag where patterns ending in `/**` would not exclude the base directory, leading to empty directories in the final image. The fix introduces an `addImplicitExcludes` function that augments the exclusion patterns to explicitly include the base directory when a pattern ends with `/**`. This function is now used in the `saveArtifacts` function in `pkg/app/sensor/artifact/artifact.go` to ensure that both the directory and its contents are excluded. A new end-to-end test has been added to `pkg/app/sensor/exclude_test.go` to verify the fix. Work in progress: The new test case is currently failing due to issues with the test environment configuration. The test is unable to locate the `mint-sensor` executable and is encountering permission errors when trying to connect to the Docker daemon. Further work is needed to resolve these test environment issues.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This submission fixes a regression in the
--exclude-patternflag and includes a new test case. The test is currently failing due to environment issues, and further assistance is needed to resolve them.Fixes #165
PR created automatically by Jules for task 9001659645140215213 started by @kcq