Skip to content

feat(schema): add input can be optional on model configuration#12

Merged
mosoriob merged 3 commits intomasterfrom
gsd/phase-12-is-optional
May 1, 2026
Merged

feat(schema): add input can be optional on model configuration#12
mosoriob merged 3 commits intomasterfrom
gsd/phase-12-is-optional

Conversation

@mosoriob
Copy link
Copy Markdown
Collaborator

Summary

  • Widen docker-publish.yml trigger from branches: '*' to branches: '**' so slashed branch names (e.g. gsd/phase-12-is-optional) actually publish images.
  • Add SAFE_BRANCH step that replaces / with - in GITHUB_REF_NAME, then tag the image with SAFE_BRANCH instead of the raw tj-actions/branch-names@v6 output (which is an invalid Docker tag when it contains /).

Mirrors fixes already applied in ui e0547dd and model-catalog-api 7109442.

Verification

  • CI on this branch HEAD: green.
  • Image ghcr.io/mintproject/graphql-engine:gsd-phase-12-is-optional and SHA tag pushed.

Test plan

  • CI builds green on slashed branch
  • Sanitized branch tag (gsd-phase-12-is-optional) and SHA tag both visible in registry

…guration_input

- up.sql: ADD COLUMN is_optional BOOLEAN NOT NULL DEFAULT FALSE
- down.sql: DROP COLUMN is_optional
- NOT NULL DEFAULT FALSE: existing junction rows backfill automatically, no UPDATE needed
- ETL untouched (D-11, D-12)
…bles.yaml

- Insert (user role, &id007 anchor): add is_optional column
- Select (anonymous role inline list): add is_optional column
- Select (user role *id007): picks up is_optional via anchor
- No update_permissions added (junction tables: insert+delete only)
- No new roles added (D-05 honored)
…eature branches build

Branch trigger '*' does not match slashed names like gsd/phase-12-is-optional,
so feature branch pushes never produced a docker image. tj-actions/branch-names
also returns the raw branch name, which is an invalid docker tag when it
contains '/'. Adds SAFE_BRANCH step (replaces '/' with '-') and tags with that
instead. Mirrors fix in ui (e0547dd) and model-catalog-api (7109442).
@mosoriob mosoriob changed the title ci: build slashed feature branches + SAFE_BRANCH tag feat(schema): add input can be optional on model configuration May 1, 2026
@mosoriob mosoriob merged commit 0d74aa1 into master May 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant