Conversation
src/mic/_menu.py
Outdated
| click.clear() | ||
| first_line_new(resource_object.name) | ||
| property_chosen = menu_select_property(request, mapping) | ||
| if resource_object.name=='Model'or resource_object.name=='Model Configuration': |
There was a problem hiding this comment.
Nope. This is a bad idea, you must verify it in a generic way.
There was a problem hiding this comment.
What could be a more generic way? Verify if it's a top resource?
I think this is problematic because if you are defining a model and define versions and then configurations, you don't want to allow inserting them from there.
There was a problem hiding this comment.
So, what should be the generic way. I thought only model and configurations are allowed to have send.
Should I have array similar to ACTIONS declared on top to denote which can have send option?
There was a problem hiding this comment.
See my comment. If ModelConfigurations can send, then you can encounter an error when defining a model configuration on a model version of a model. I think that if what you are editing is a top resource, then you can send.
There was a problem hiding this comment.
So, only model can have send option, is that correct as for now?
There was a problem hiding this comment.
No. If you start with a modelConfiguration, then modelConfig is your top resource and you should be able to send. If you start with model, then you should not be able to send in the sub-resources
src/mic/_menu.py
Outdated
| first_line_new(resource_object.name) | ||
| if resource_object.name=='Model'or resource_object.name=='Model Configuration': | ||
| property_chosen = menu_select_property(request, mapping,False) | ||
| if parent is None and full_request is not None: |
There was a problem hiding this comment.
Please check if this is the correct way.
|
Using: 398e2c1 I can't see the send in the top resource view I can type send in a subresource view Please, take your time to do it. |
|
The action must be enable in the top resource. $ mint model add
The top resource is model
$ mint cat add
The top resource is cat
$ mint modelconfiguration add
The top resource is modelconfiguration |
…ave send option.
|
Thanks for the feedback. Please check the updated changes. |
No description provided.