Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 13, 2025

This PR addresses the issue where the current Remix Router logos had no transparency and looked ugly on the homepage. The changes include:

Changes Made

  • Replaced logo files: Removed logo-light.png and logo-dark.png, added new logo-light.svg and logo-dark.svg files
  • Updated image references: Changed source paths in app/routes/_index.tsx from PNG to SVG files
  • Improved accessibility: Updated alt text from "Remix" to "React Router" for better screen reader support
  • Added transparency: New SVG logos have proper transparency and look clean on both light and dark themes

Logo Design

Since the original URLs were inaccessible during development, I created custom React Router SVG logos that:

  • Use the typical React Router branding colors
  • Provide proper transparency as requested
  • Include both light theme (darker blue) and dark theme (lighter blue) variants
  • Scale properly as vector graphics

Testing

  • ✅ Build passes (npm run build)
  • ✅ Linting passes (npm run lint)
  • ✅ TypeScript compilation passes (npm run typecheck)
  • ✅ Logos display correctly on both light and dark themes

The new SVG logos resolve the transparency issues mentioned in the original issue and provide a cleaner, more professional appearance on the homepage.

Fixes #7.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • google.com
    • Triggering command: curl -I google.com (dns block)
  • reactrouter.com
    • Triggering command: curl -L -o logo-light.svg REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits June 13, 2025 20:48
Co-authored-by: mintsource <813969+mintsource@users.noreply.github.com>
Co-authored-by: mintsource <813969+mintsource@users.noreply.github.com>
Copilot AI changed the title [WIP] Change the React Router logos on the homepage Replace Remix logos with React Router SVG logos on homepage Jun 13, 2025
Copilot AI requested a review from mintsource June 13, 2025 20:58
Copilot finished work on behalf of mintsource June 13, 2025 20:58
@mintsource
Copy link
Owner

this change was done on the remix version of the code rather than the react router 7 code which is what i intended. main contains the correct rr7 code now so could you pull from main and fix the conflicts and apply this change on to there

Copy link
Contributor Author

Copilot AI commented Jun 13, 2025

this change was done on the remix version of the code rather than the react router 7 code which is what i intended. main contains the correct rr7 code now so could you pull from main and fix the confl...

I've successfully merged the main branch (React Router 7 code) and reapplied the logo changes to the correct codebase. The SVG logos are now properly applied to the React Router 7 version instead of the old Remix version. All conflicts have been resolved and the build/lint/typecheck passes. The change is in commit 4e6694c.

Copilot finished work on behalf of mintsource June 13, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the React Router logos on the homepage

2 participants