Skip to content

Several code quality improvements #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaovpmamede merged 3 commits into from
Sep 2, 2016
Merged

Several code quality improvements #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb61577
Correct semantic for copyright smallprint
Sep 2, 2016
e4e9776
Fix BEM variation nomenclature for 'btn' class
Sep 1, 2016
43598aa
Remove meta http-equiv for Chrome Frame
Sep 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</ul>
</div>

<p class="property">© 2016, Minuscode All rights reserved</p>
<small class="property">© 2016, Minuscode All rights reserved</small>

</div>

Expand Down
2 changes: 1 addition & 1 deletion _layouts/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>{{ page.title }}</title>
<meta name="viewport" content="width=device-width">
<meta name="twitter:card" content="summary" />
Expand Down
2 changes: 1 addition & 1 deletion contact/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ <h2 itemprop="name"><i class="icon-briefcase"></i>Minuscode</h2>
<input type="email" name="email" placeholder="E-mail" autocomplete="off" required>
<textarea rows="9" name="message" placeholder="Message" required></textarea>
</fieldset>
<button type="submit" class="btn btn-red">Send &rarr;</button>
<button type="submit" class="btn btn--red">Send &rarr;</button>
<!-- <input type='submit' value='Test form' /> -->
</form>

Expand Down
4 changes: 2 additions & 2 deletions css/src/ui/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}
}

.btn-red {
.btn--red {
background: $red;
border: 2px solid $red;
color: #fff;
Expand All @@ -28,4 +28,4 @@
background: none;
color: $red;
}
}
}
2 changes: 2 additions & 0 deletions css/src/ui/_page-foot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@
}

.property {
width: 100%;
display: block;
color: #fff;
font-family: $brand-sans-serif;
margin: 30px 0 0;
Expand Down
6 changes: 4 additions & 2 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4937,6 +4937,8 @@ html {
}
/* line 109, src/ui/_page-foot.scss */
.main-footer .property {
width: 100%;
display: block;
color: #fff;
font-family: "PT Sans Caption", sans-serif;
margin: 30px 0 0;
Expand Down Expand Up @@ -5057,15 +5059,15 @@ html {
}

/* line 20, src/ui/_buttons.scss */
.btn-red {
.btn--red {
background: #c94055;
border: 2px solid #c94055;
color: #fff;
letter-spacing: 1px;
font-weight: 400;
}
/* line 27, src/ui/_buttons.scss */
.btn-red:hover {
.btn--red:hover {
background: none;
color: #c94055;
}
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ <h2>
<span>or a brand activation, we can help you <strong>build it.</strong></span>
</h2>

<a href="/contact" class="btn btn-red link--arrow-end">Get a Quote</a>
<a href="/contact" class="btn btn--red link--arrow-end">Get a Quote</a>
</div>

</div><!-- /masthead -->
Expand Down