[pull] master from ray-project:master#3155
Merged
pull[bot] merged 10 commits intomiqdigital:masterfrom Jun 3, 2025
Merged
Conversation
Signed-off-by: fscnick <fscnick.dev@gmail.com> Signed-off-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org> Co-authored-by: Douglas Strodtman <douglas@anyscale.com>
- Make all tests in `test_runtime_env.py` use shared cluster fixture. - Move other tests to `test_runtime_env_standalone.py`. - Split the tests in `test_runtime_env_2.py` into one of these two files. Depends on: #53479 --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…53434) ## Summary This PR replaces the use of `requests` with `httpx` in our test client logic to resolve an issue where sockets are not properly released after making HTTP requests. This was causing interference in our test suite ### Background We observed that even after a simple request is completed and the process exits, the socket used by `requests` remains in `TIME_WAIT` or `FIN_WAIT1` state: ``` sconn(fd=-1, family=AF_INET, type=SOCK_STREAM, laddr=127.0.0.1:8000, raddr=127.0.0.1:50520, status='FIN_WAIT1', pid=None) ``` This issue persists even when: - Using `requests.Session()` in a with block. - Explicitly calling `.close()` on the response object. In contrast, using `httpx` immediately releases the socket, as confirmed via `psutil` and `ss`. **Why this matters** In our test suite: - Port reuse is disabled. - Each replica is assigned a unique port. - Both server and client run on the same machine. As a result, if the client leaves sockets in a lingering state, those ports appear as “in use” to the OS. This causes subsequent replicas to fail to bind to their assigned ports, breaking the test. Signed-off-by: abrar <abrar@anyscale.com>
Fix `iter_rows` involving `_get_max_chunk_size` - Calling `_get_max_chunk_size` in `ArrowBlockAccessor` constructor has overhead. - So moving `_get_max_chunk_size` call into `iter_rows` conditionally only for `public_row_format`. --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Stephanie Wang <swang@cs.berkeley.edu> Signed-off-by: Stephanie wang <smwang@cs.washington.edu> Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Co-authored-by: Jiajun Yao <jeromeyjj@gmail.com>
…ad (#53491) If actors are force-killed with `ray.kill`, they can end up in the DEAD state even if max_restarts is infinite. This can cause our assertion to fail and lead to confusing errors. Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
so that pytest is always installed Signed-off-by: abrar <abrar@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )