Skip to content

Update thinking budget configs#511

Merged
KaQuMiQ merged 1 commit into
mainfrom
feature/gemini
May 15, 2026
Merged

Update thinking budget configs#511
KaQuMiQ merged 1 commit into
mainfrom
feature/gemini

Conversation

@KaQuMiQ
Copy link
Copy Markdown
Collaborator

@KaQuMiQ KaQuMiQ commented May 15, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d3b76150-7210-4c83-828a-d69c113218e2

📥 Commits

Reviewing files that changed from the base of the PR and between afd5358 and 3dfe4ad.

📒 Files selected for processing (3)
  • pyproject.toml
  • src/draive/gemini/config.py
  • src/draive/gemini/live.py

Walkthrough

This PR extends Gemini Live session configuration by adding two new optional settings to GeminiConfig: thinking_level (with values "minimal", "low", "medium", "high") and context_window_compression (boolean). Resolver helper functions convert these config values to Gemini API types with validation. The _live_connect_config function is updated to conditionally enable context window compression, apply the media resolution resolver, and configure thinking settings by preferring the new thinking_level option while falling back to thinking_budget when not provided. The package version is incremented from 0.106.3 to 0.106.4.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • miquido/draive#441: Both PRs modify Gemini thinking configuration logic by handling thinking-related settings (thinking_level in this PR and thinking_budget elsewhere), with coordinated changes across live.py and generating.py.
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Update thinking budget configs' refers to a real aspect of the change but is overly broad and somewhat misleading. The changeset primarily adds new thinking_level configuration options and context_window_compression, with only minor references to thinking budget fallback logic. Consider a more specific title like 'Add thinking_level and context_window_compression to GeminiConfig' to better reflect the main changes introduced in this PR.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether any description content is related to the changeset. Add a pull request description that explains the purpose of adding thinking_level and context_window_compression parameters to GeminiConfig and how they affect Gemini Live session configuration.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/gemini

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KaQuMiQ KaQuMiQ merged commit e2c36fa into main May 15, 2026
3 checks passed
@KaQuMiQ KaQuMiQ deleted the feature/gemini branch May 15, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant