Allow one reference tempo and both estimate tempi to be zero. The ide…#299
Merged
craffel merged 10 commits intomir-evaluation:masterfrom Jan 18, 2019
Merged
Allow one reference tempo and both estimate tempi to be zero. The ide…#299craffel merged 10 commits intomir-evaluation:masterfrom
craffel merged 10 commits intomir-evaluation:masterfrom
Conversation
…a here is that some tracks in the ground truth may not be ambigious and some estimators might be unable to produce any reasonable value and therefore choose zero for both estimate tempi.
For some tests, the difference between the scores produced by Travis' build and my own build is as large as 3.89588121e-04. In practice, we shouldn't care much about differences larger than 10e-3 for separation tasks since it would be very unusual for anyone to pay attention to differences this small when comparing source separation algorithms.
todense() returns a numpy matrix object, whereas toarray returns a numpy ndarray. The former causes a DeprecationWarning. The flood of DeprecationWarnings in our tests eventually causes Travis to fail.
Using a list causes a warning with the latest numpy.
matplotlib v3+ omits the matplotlib.testing.noseclasses module which our tests use. This change forces using an old version of matplotlib as a temporary fix. In order to use matplotlib >=2.1.1, <3 on Py3 we can't test on py3.4 anymore.
Collaborator
|
Can you rebase? |
…a here is that some tracks in the ground truth may not be ambigious and some estimators might be unable to produce any reasonable value and therefore choose zero for both estimate tempi.
Collaborator
|
Looks like PEP-8 is failing. |
Contributor
Author
|
Oh no—not again. Sorry. Let me look. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…a here is that some tracks in the ground truth may not be ambiguous and some estimators might be unable to produce any reasonable value and therefore choose zero for both estimate tempi.
This is a little more than what we had talked about in #298, but I believe it to be reasonable.