Skip to content

Drop Python 2#359

Merged
craffel merged 10 commits intomir-evaluation:masterfrom
carlthome:patch-3
Jul 5, 2023
Merged

Drop Python 2#359
craffel merged 10 commits intomir-evaluation:masterfrom
carlthome:patch-3

Conversation

@carlthome
Copy link
Copy Markdown
Contributor

@carlthome carlthome commented Jul 2, 2023

IIRC future and six were for the Python 2 -> 3 migration. As Python 2 has passed EOL it's probably not necessary to mention it anymore.

@craffel
Copy link
Copy Markdown
Collaborator

craffel commented Jul 5, 2023

If we are going to do this, we need to remove imports/uses of six and future from the library and should probably add python_requires to the setup.py

@carlthome
Copy link
Copy Markdown
Contributor Author

If we are going to do this, we need to remove imports/uses of six and future from the library and should probably add python_requires to the setup.py

Ah, good catch! I got fooled by six and future being transitive dependencies and thus the tests passed.

@carlthome carlthome changed the title Drop legacy dependencies Drop Python 2 Jul 5, 2023
@craffel
Copy link
Copy Markdown
Collaborator

craffel commented Jul 5, 2023

Thanks!

@craffel craffel merged commit bdef49c into mir-evaluation:master Jul 5, 2023
@carlthome carlthome deleted the patch-3 branch July 5, 2023 22:09
@bmcfee bmcfee added this to the 0.8 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants