Fix length error in sonify.time_frequency#374
Merged
bmcfee merged 4 commits intomir-evaluation:mainfrom Mar 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 88.31% 88.32% +0.01%
==========================================
Files 19 19
Lines 2875 2878 +3
==========================================
+ Hits 2539 2542 +3
Misses 336 336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Test failure is unrelated, appears to be a resurgence of a heisenbug in bsseval on osx. 🤦 |
Collaborator
Author
|
I added one more test here to cover the case where the input length is shorter than the provided input. Otherwise I think this is good to go. We shouldn't let the OSX failure block merging this PR. |
Collaborator
Author
|
Lol, rerunning the tests passed this time with no changes. OSX is great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #371 by separating out the slicing logic for time_frequency generation.
I've unskipped the test that was previously failing and things seem good to go.