Minor Python 2 to Python 3 changes#387
Merged
bmcfee merged 7 commits intomir-evaluation:mainfrom Dec 6, 2024
Merged
Conversation
Contributor
Author
|
Ah, so |
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmcfee
approved these changes
Aug 18, 2024
Collaborator
bmcfee
left a comment
There was a problem hiding this comment.
All looks good to me, thanks!
bmcfee
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor nitpicks but perhaps nice to keep the syntax fresh since Python 3.8 is now the latest non-EOL version.
Nothing major and not urgent to fix. And TBH arguably not worth merging in case this breaks unexpected monkey patches in the wild. This is just me sitting at an airport with a coffee and reading the source. 😄