Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
Author
|
Rewrote this a bit following #413 (comment) ; I'm not wild about raising an IOError from a TypeError, for many reasons. (It's obtuse, provides no additional information, and adds complexity. It also doesn't do anything useful if open throws a different kind of error.) I've done it here so that we preserve the type of exception raised in case of failure, as changing it would constitute API breakage and I'd rather not do that in a minor release (as this is slated for). But going forward (0.9), we should rip out this indirection and just let open() throw whatever exception it likes back up the stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #415
Fixes #413
This PR adds support for
pathlib.Pathobjects in allmir_eval.ioloaders. (Easy fix, just adding a case to the_opencontext manager's type check.)I've added one unit test that hits
load_delimitedwith either string or Path input. I think this is sufficient since: A) almost all other loaders run throughload_delimited, and B) those that don't use the same_opencontext manager anyway.Since I was in .io anyway, I added a deprecation on
load_wav.Assuming this passes CI, I think it should be good to merge.