Inject login-shell PATH into spawned subprocesses

[nickdirienzo]

Summary

• GUI-launched Flight (Sparkle, Finder) inherits launchd's stripped PATH (/usr/bin:/bin:/usr/sbin:/sbin). ClaudeAgent spawns /usr/bin/env claude and WorktreeSetupService runs pnpm install via zsh -s, neither of which loaded the user's actual PATH — so claude silently exited 127 every turn and pnpm install couldn't find pnpm. From flight-fast-ray-9916.log: two >>> STDIN writes, zero stdout, no errors anywhere.
• New EnvironmentService captures the user's PATH via zsh -ilc 'printf %s "$PATH"' once at app launch (using -ilc not -lc because ~/.local/bin and language-version managers typically live in .zshrc, not .zprofile). All three ShellService spawn paths and both ClaudeAgent spawn branches now set process.environment = EnvironmentService.baseEnvironment(...).
• ClaudeAgent now drains stderr into its per-worktree log (<<< STDERR: ...) so the next time something like this happens we see the actual error. On clean non-zero exits (reason == .exit && exitCode != 0), fires a metadata-only Sentry event via a new SentryService bridge — sends only command + exit code + correlation UUID. Stderr stays on-box because CLI tools can include credentials in error output. .uncaughtSignal exits (user-pressed-stop SIGINT, our own SIGTERM teardown) are intentionally skipped.
• Tests/FlightAppTests/EnvironmentInheritanceTests.swift pins the invariant that spawned subprocesses inherit EnvironmentService.path, keyed off runScriptStreaming (uses zsh -s, no rc-file mutation, so the assertion is exact).

Test plan

• swift test --filter EnvironmentInheritanceTests — all 3 pass
• ./build.sh — clean build
• Repro: launched fresh Flight.app, opened flight/fast-ray-9916, sent a message; log went 4 → 7 lines, claude responded with a session_id and a normal assistant reply
• Verify pnpm install resolves in a fresh worktree on a Sparkle-launched Flight (the fast-elm-2629 reproducer)

🤖 Generated with Claude Code