Use fcntl(F_FULLFSYNC) on OSX
#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The man page for `fsync` on OS X warns that it's not enough and doesn't prevent arbitrary re-ordering of writes by the drive. This means that an application taking care to write structures in a certain order bracketted by calls to `flush` to maintain invariants will be disappointed by the behaviour of `fsync`. Switch to `fcntl(F_FULLFSYNC)` as recommended by the manpage. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The man page for
fsyncon OSX explains that it is insufficient to implement the desired semantics offlushi.e. that all written blocks have definitely hit the physical disk. Instead we must usefcntl(F_FULLFSYNC).Fixes #49