tests -> alcotest; more tests; fix big writes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calling `writev` with a list whose lenv was greater than the size of 1 page would result in an Invalid_argument exception. Instead of the buggy reimplementation of `Cstruct.concat`, just use `Cstruct.concat`. Also, the module type from mirage/types/V1.mli specifies that `write` and `writev` take `buffer` and `buffer list` respectively, rather than `page_aligned_buffer` and `page_aligned_buffer list`. Fix some comments and variable names in `write` which weren't correct in this light.
Contributor
Author
|
This package could probably use some build-system attention, but I'm happy to leave it here for this PR (considering #13 , the situation isn't worse than it was) . |
mato
added a commit
to mato/mirage-net-solo5
that referenced
this pull request
Aug 19, 2016
This is a sync with the changes in mirage/mirage-net-unix#26.
Member
|
great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disconnect, and make it passwritevwith a list of combined length > 1 page, and make it pass