Merged
Conversation
to later share it with git wire proto v2 implementation
'pkt_len_unsafe' * comment 'junk_pkt'
because fns that raise it are exposed
dinosaure
approved these changes
Dec 10, 2020
Member
dinosaure
left a comment
dinosaure
left a comment
There was a problem hiding this comment.
Great! Nothing to say, it's perfect and if it helps your for Smart v2. I will merge, just waiting the CI 👍.
Contributor
Author
|
Thanks! I just hope I don't end up adding bugs :D |
Member
Fuzzers test your implementation and assert some assumptions, we can believe on them and I did not find deep changes which can update behaviors. I think it's fine. |
Contributor
Author
|
Thanks!
…On Thu, 10 Dec 2020 at 15:16, Calascibetta Romain ***@***.***> wrote:
Merged #424 <#424> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#424 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4YR643B7BFTHWKOIMNB3DSUCNWBANCNFSM4UTSOD5Q>
.
|
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 9, 2021
… git-unix (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 9, 2021
…t-unix and git-mirage (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 9, 2021
…t-unix and git-mirage (3.0.0) CHANGES: - Rewrite of `ocaml-git` (@dinosaure, mirage/ocaml-git#395) - Delete useless constraints on digestif's signature (@dinosaure, mirage/ocaml-git#399) - Add support of CoHTTP with UNIX and MirageOS (@ulugbekna, mirage/ocaml-git#400) - Add progress reporting on fetch command (@ulugbekna, mirage/ocaml-git#405) - Lint dependencies on packages (`git-cohttp-unix` and `git-cohttp-mirage`) and update to the last version of CoHTTP (@hannesm, mirage/ocaml-git#407) - Fix internal `Cstruct_append` implementation (@dinosaure, mirage/ocaml-git#401) - Implement shallow commit (@dinosaure, mirage/ocaml-git#402) - Update to `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#408) (deleted by the integration of `mimic`) - Delete use of `ocurl` (@dinosaure, mirage/ocaml-git#410) - Delete the useless **old** `git-mirage` package (@hannesm, mirage/ocaml-git#411) - Fix about unresolved endpoint with `conduit.3.0.0` (@dinosaure, mirage/ocaml-git#412) - Refactors fetch command (@ulugbekna, mirage/ocaml-git#404) - Fix ephemerons about temporary devices (@dinosaure, mirage/ocaml-git#413) - Implementation of `ogit-fetch` as an example (@ulugbekna, mirage/ocaml-git#406) - Rename `nss` to `git-nss` (@dinosaure, mirage/ocaml-git#415) - Refactors `git-nss` (@ulugbekna, mirage/ocaml-git#416) - Update README.md (@ulugbekna, mirage/ocaml-git#417) - Replace deprecated `Fmt` functions (@ulugbekna, mirage/ocaml-git#421) - Delete physical equality (@ulugbekna, mirage/ocaml-git#422) - Rename `prelude` argument by `uses_git_transport` (@ulugbekna, mirage/ocaml-git#423) - Refactors Smart decoder (@ulugbekna, mirage/ocaml-git#424) - Constraint to use `fmt.0.8.7` (@dinosaure, mirage/ocaml-git#425) - Small refactors in `git-nss` (@dinosaure, mirage/ocaml-git#427) - Delete `conduit.3.0.0` and replace it by `mimic` (@dinosaure, mirage/ocaml-git#428) - Delete the useless `verify` function on `fetch` and `push` (@dinosaure, mirage/ocaml-git#429) - Delete `pin-depends` on `awa` (@dinosaure, mirage/ocaml-git#431)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added some docs
moved
nss/decoder.ml/iandnss/encoder.ml/itogit-nss.pkt-linelib to be able to re-use it in wire protocol v2made some refactorings (would appreciate your comment if I'm using
Bytes.unsafe_of_stringcorrectly)there are a couple of functions that are defined but not used, which I could remove, but that's up to you
I can also revert some commits if you don't like them