-
-
Notifications
You must be signed in to change notification settings - Fork 3
Workaround inconsistent naming for marisa-trie by not using wheel #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the GitHub Actions workflow for building the Changes
Sequence Diagram(s)sequenceDiagram
participant GHA as GitHub Actions
participant Pip as pip
participant Build as Build System
GHA->>Pip: Execute `pip wheel --no-binary marisa_trie`
Pip->>Build: Compile marisa-trie from source
Build-->>Pip: Return the built wheel
Pip-->>GHA: Deliver the built wheel
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/python.yml (1)
47-50: Clarify and Verify the Build Command for marisa-trie:
The updated command now employs the--no-binary marisa_trieoption to force building from source, which should yield the desired file naming convention. The accompanying comment explains this rationale; however, the presence of theFIXMEtag suggests the workaround is temporary. Consider updating or removing theFIXMEtag once the issue is fully resolved. Additionally, verify that this change is compatible with the dependency resolution in your requirements file and produces the expected wheel filename during the build process.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/python.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: deb
Summary by CodeRabbit