Conversation
`miren env set` and `env delete` would create a new version and exit immediately — no deployment record, no activation polling, no route display. Meanwhile `deploy` and `rollback` both do all of that. Added SetEnvVars/DeleteEnvVars RPCs to the deployment service so the CLI can get back a deployment record + access info. Extracted the shared env var mutation logic into api/app/envvar.go so both the deployment server (new methods) and the app server (old Crud methods) use the same code.
evanphx
approved these changes
Feb 23, 2026
phinze
deleted the
phinze/mir-701-miren-env-set-should-watch-deploy-and-print-routes-like
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
env setandenv deletewere the odd ones out — they'd create a new version and bail, whiledeployandrollbackboth watch activation and print routes. Now they all behave the same way.SetEnvVarsandDeleteEnvVarsRPCs to the deployment serviceapi/app/envvar.goCloses MIR-701