Resolve short IDs for sandbox exec, logs, and deploy cancel

[phinze]

Short IDs (those 3-8 char base58 suffixes we show in most output) weren't resolving in a handful of commands, which made them useless for the exact case they're most useful: typing a short ID you just saw in a log or status message. Worst offender was deploy cancel, which reported success but silently no-op'd because the write-back used the original unresolved short ID, leaving the deploy lock stuck until its 30-minute timeout.

First commit teaches EntityServer.Get's short ID fallback to handle kind-prefixed input like sandbox/3sA. The index stores bare suffixes, but the CLI often normalizes to a kind/id form before sending. That single change also fixes sandbox-pool set-desired and any other command that flows through the entity server with a prefixed short ID.

Second commit tackles the three commands called out in the issue. sandbox exec and logs sandbox never resolved IDs at all and needed explicit resolution added. deploy cancel was resolving on read but using the original string for the write; fixed by reassigning from the Get response.

Closes MIR-1002

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 078c3baf-3d8b-4563-8663-fc31c6fe2fc2

📥 Commits

Reviewing files that changed from the base of the PR and between c3b3acc and 3f38764.

📒 Files selected for processing (1)

• servers/logs/logs.go

🚧 Files skipped from review as they are similar to previous changes (1)

• servers/logs/logs.go

---

📝 Walkthrough

Walkthrough

The PR adds ID resolution across several servers. DeploymentServer.CancelDeployment now replaces the provided deploymentId with the resolved entity ID before further operations. EntityServer.Get gains an EtcdStore fallback that, when an ID contains /, strips up to the last / and retries the DBShortId lookup. Server.Exec pre-resolves short container/entity IDs and uses the full ID in the containerd selector. Logs server adds resolveSandboxID and uses it in SandboxLogs and resolveLogTarget. Tests now create a sandbox entity before streaming logs.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@servers/logs/logs.go`:
- Around line 201-205: The resolveSandboxID function currently maps every error
from s.EC.EAC().Get into a "not found" message; change it to inspect the
returned error and only convert it to a not-found error when the underlying
error actually indicates a missing sandbox (e.g. use errors.Is(err, ErrNotFound)
or, if the EAC client returns gRPC errors, check status.Code(err) ==
codes.NotFound), otherwise return the original error (or wrap it while
preserving the cause with %w) so upstream/service failures are not masked;
update resolveSandboxID to perform that conditional check and only
fmt.Errorf("sandbox %q not found: %w", sandboxID, err) for true not-found cases.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a066b34-29ca-43e0-aef7-2974eaf4b70b

📥 Commits

Reviewing files that changed from the base of the PR and between 8149629 and c3b3acc.

📒 Files selected for processing (5)

• servers/deployment/server.go
• servers/entityserver/entityserver.go
• servers/exec/exec.go
• servers/logs/logs.go
• servers/logs/logs_test.go