Remove routeoidc labs flag#788
Conversation
Route protection is stable enough to no longer require opt-in via MIREN_LABS=routeoidc. CLI commands (route protect/unprotect, auth provider add/list/show/remove) are now always registered, and the OIDC middleware no longer checks the feature flag before enforcing authentication.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Comment |
d7b8378 to
07ad137
Compare
07ad137 to
2a890dc
Compare
Summary
routeoidcfromfeatures.yamland regenerate labs coderoute protect,route unprotect,auth provider *)if !labs.RouteOIDC()guard checks from command implementations and OIDC middlewareTest plan
go build ./...passesmake lint— all issues pre-existing, none in changed fileshack/it ./pkg/labs/...— 7 tests passhack/it ./servers/httpingress/...— 50 tests passrouteoidc/RouteOIDC/FeatureRouteOIDCin source