Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why spawning objects causes AddObserver already added message #25

Closed
SoftwareGuy opened this issue Sep 1, 2018 · 3 comments
Closed

Investigate why spawning objects causes AddObserver already added message #25

SoftwareGuy opened this issue Sep 1, 2018 · 3 comments

Comments

@SoftwareGuy
Copy link
Contributor

Describe the bug
When spawning objects into the scene when connected, sometimes you can get a message that says "AddObserver: Already added observer to (gameobject). Maybe the function was called twice. Or perhaps the connection layer assigned the same ID twice ....." or something along those lines. We need to investigate why that's happening and stop emitting that warning unless people are actually deliberately trying to mess things up.

To Reproduce
Most of the time it's triggered when the player prefab is spawned by AddPlayerForConnection I believe. Can also be triggered if you use Auto Create Player option in the Network Manager.

Expected behavior
We should make sure that when objects are spawned that AddObserver functions are called once, and not multiple times.

I will investigate this further and see if there's any leads I can bring up.
@miwarnec
Copy link
Collaborator

miwarnec commented Sep 3, 2018

added this to track down a previous bug. will remove the message again soon

@SoftwareGuy
Copy link
Contributor Author

ah ok. so this was just as a placeholder or debug aid? it's harmless?

@paulpach
Copy link
Contributor

paulpach commented Oct 5, 2018

Warning has been removed, reopen if it happens again

@paulpach paulpach closed this as completed Oct 5, 2018
@SoftwareGuy SoftwareGuy mentioned this issue Oct 12, 2018
Closed
Lymdun pushed a commit to Lymdun/Mirror that referenced this issue Jan 17, 2020
@paulpach
fix: remove samples from upm package (MirrorNetworking#25)
a71e21f
Lymdun pushed a commit to Lymdun/Mirror that referenced this issue Jan 17, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
5f1b57e 
# 1.0.0 (2020-01-04)

### Bug Fixes

* (again) Telepathy updated to latest version (Send SocketExceptions now disconnect the player too) ([46eddc0](MirageNet/Mirage@46eddc0))
* [MirrorNetworking#1359](https://github.com/MirrorNG/MirrorNG/issues/1359). Revert "Destroy objects owned by this connection when disconnecting ([MirrorNetworking#1179](https://github.com/MirrorNG/MirrorNG/issues/1179))" ([4cc4279](MirageNet/Mirage@4cc4279))
* [MirrorNetworking#573](MirageNet/Mirage#573) (part 1) NetworkScenePostProcess handles NetworkIdentities of all scenes except DontDestroyOnLoad. this way it works for additively loaded scenes too. ([c1af84e](MirageNet/Mirage@c1af84e))
* [MirrorNetworking#573](MirageNet/Mirage#573) (part 2) NetworkManager detects additive scene loads and respawns objects on server/client again ([e521a20](MirageNet/Mirage@e521a20))
* [MirrorNetworking#573](MirageNet/Mirage#573) NullReferenceException because destroyed NetworkIdentities were never removed from sceneIds dict ([a2d6317](MirageNet/Mirage@a2d6317))
* [MirrorNetworking#609](MirageNet/Mirage#609) by spawning observers in NetworkServer.AddPlayerForConnection after setting the controller. There is no point in trying to spawn with a null controller in SetReady, because by definition no one can observer something that is null. ([MirrorNetworking#623](MirageNet/Mirage#623)) ([5c00577](MirageNet/Mirage@5c00577))
* [MirrorNetworking#640](MirageNet/Mirage#640) InternalReplacePlayerForConnection calls SpawnObserversForConnection now too ([bdf12c8](MirageNet/Mirage@bdf12c8))
* [MirrorNetworking#651](MirageNet/Mirage#651) GetSceneAt assumes default scene ([MirrorNetworking#654](MirageNet/Mirage#654)) ([65eaba1](MirageNet/Mirage@65eaba1))
* [MirrorNetworking#652](MirageNet/Mirage#652) OnPostProcessScene includes disabled NetworkIdentities in scene ([ee2ace8](MirageNet/Mirage@ee2ace8))
* [MirrorNetworking#679](MirageNet/Mirage#679) package for unity ([4a6a4df](MirageNet/Mirage@4a6a4df))
* [MirrorNetworking#679](MirageNet/Mirage#679) unity package ([9895647](MirageNet/Mirage@9895647))
* [MirrorNetworking#692](MirageNet/Mirage#692) by always adding connectionToClient when rebuilding observers ([ab44ac8](MirageNet/Mirage@ab44ac8))
* [MirrorNetworking#718](MirageNet/Mirage#718) remove Tests folder from unitypackage ([MirrorNetworking#827](MirageNet/Mirage#827)) ([7e487af](MirageNet/Mirage@7e487af))
* [MirrorNetworking#791](MirageNet/Mirage#791) corrected assembly paths passed to weaver ([MirrorNetworking#803](MirageNet/Mirage#803)) ([3ba546e](MirageNet/Mirage@3ba546e))
* [MirrorNetworking#791](MirageNet/Mirage#791) stack overflow in the weaver ([MirrorNetworking#792](MirageNet/Mirage#792)) ([7b57830](MirageNet/Mirage@7b57830))
* [MirrorNetworking#840](MirageNet/Mirage#840) by allowing Mirror to respect the forceHidden flag ([MirrorNetworking#893](MirageNet/Mirage#893)) ([3ec3d02](MirageNet/Mirage@3ec3d02))
* added new read/write symbol params ([MirrorNetworking#806](MirageNet/Mirage#806)) ([3a50ca6](MirageNet/Mirage@3a50ca6))
* Added WriteBytesAndSize tests, and fixed the function to be pedantic. ([MirrorNetworking#773](MirageNet/Mirage#773)) ([72e4e55](MirageNet/Mirage@72e4e55))
* Additive scene can respawn objects safely ([MirrorNetworking#1270](https://github.com/MirrorNG/MirrorNG/issues/1270)) ([8899d20](MirageNet/Mirage@8899d20))
* ArraySegment<byte> work in Messages ([MirrorNetworking#919](MirageNet/Mirage#919)) ([981ba7c](MirageNet/Mirage@981ba7c))
* Call hooks when initializing objects OnStartServer on host ([MirrorNetworking#1249](https://github.com/MirrorNG/MirrorNG/issues/1249)) ([7aa7815](MirageNet/Mirage@7aa7815))
* call Obsoleted OnStartClient ([MirrorNetworking#681](MirageNet/Mirage#681)) ([8dea50e](MirageNet/Mirage@8dea50e))
* call OnStartClient only once in room ([MirrorNetworking#1264](https://github.com/MirrorNG/MirrorNG/issues/1264)) ([4d373c5](MirageNet/Mirage@4d373c5))
* check event prefix ([7417b68](MirageNet/Mirage@7417b68))
* ClientRpc methods now work accross assemblies ([MirrorNetworking#1129](MirageNet/Mirage#1129)) ([13dbcb9](MirageNet/Mirage@13dbcb9)), closes [MirrorNetworking#1128](MirageNet/Mirage#1128)
* Cmds can be called from child classes in other assemblies ([d8a98d8](MirageNet/Mirage@d8a98d8)), closes [MirrorNetworking#1108](MirageNet/Mirage#1108)
* code generation works with il2cpp again ([MirrorNetworking#1056](MirageNet/Mirage#1056)) ([8738562](MirageNet/Mirage@8738562))
* destroy owned objects ([MirrorNetworking#1352](https://github.com/MirrorNG/MirrorNG/issues/1352)) ([d7a58d2](MirageNet/Mirage@d7a58d2)), closes [MirrorNetworking#1346](https://github.com/MirrorNG/MirrorNG/issues/1346) [MirrorNetworking#1206](https://github.com/MirrorNG/MirrorNG/issues/1206) [MirrorNetworking#1351](https://github.com/MirrorNG/MirrorNG/issues/1351)
* do not accumulate changes if there are no observers fixes [MirrorNetworking#963](MirageNet/Mirage#963) ([MirrorNetworking#964](MirageNet/Mirage#964)) ([64a0468](MirageNet/Mirage@64a0468))
* Do not call InternalAddPlayer twice ([MirrorNetworking#1246](https://github.com/MirrorNG/MirrorNG/issues/1246)) ([7119dd1](MirageNet/Mirage@7119dd1))
* don't call hook in host if no change,  fixes [MirrorNetworking#1142](MirageNet/Mirage#1142) ([MirrorNetworking#1143](MirageNet/Mirage#1143)) ([d8ce80f](MirageNet/Mirage@d8ce80f))
* don't call OnStartLocalPlayer twice ([MirrorNetworking#1263](https://github.com/MirrorNG/MirrorNG/issues/1263)) ([c753089](MirageNet/Mirage@c753089))
* don't convert null arrays to empty array ([MirrorNetworking#913](MirageNet/Mirage#913)) ([dd758ca](MirageNet/Mirage@dd758ca))
* Don't disconnect host ([MirrorNetworking#608](MirageNet/Mirage#608)) ([c1707e5](MirageNet/Mirage@c1707e5))
* Don't give host player authority by default ([MirrorNetworking#1158](MirageNet/Mirage#1158)) ([1fc1ed2](MirageNet/Mirage@1fc1ed2))
* Don't increment counter in Awake ([MirrorNetworking#971](MirageNet/Mirage#971)) ([45b7118](MirageNet/Mirage@45b7118))
* Don't set asset id for scene objects ([7e40232](MirageNet/Mirage@7e40232))
* Don't set framerate in host mode ([4644bc4](MirageNet/Mirage@4644bc4))
* Don't throw exception getting address ([7df3ce3](MirageNet/Mirage@7df3ce3))
* don't use obsolete method ([12437ba](MirageNet/Mirage@12437ba))
* Draw SyncVar label for Unity objects inline  ([MirrorNetworking#1291](https://github.com/MirrorNG/MirrorNG/issues/1291)) ([a0425e4](MirageNet/Mirage@a0425e4))
* Dummy file for SyncListStructProcessor.cs ([MirrorNetworking#798](MirageNet/Mirage#798)) ([75e4f15](MirageNet/Mirage@75e4f15))
* error when there are no network behaviors ([MirrorNetworking#1303](https://github.com/MirrorNG/MirrorNG/issues/1303)) ([dbe0643](MirageNet/Mirage@dbe0643))
* error with missing assemblies ([MirrorNetworking#1052](MirageNet/Mirage#1052)) ([00eb23a](MirageNet/Mirage@00eb23a)), closes [MirrorNetworking#1051](MirageNet/Mirage#1051)
* Fix error scene error message in host mode ([838d4f0](MirageNet/Mirage@838d4f0))
* hasAuthority is now visible in all overrides ([MirrorNetworking#1251](https://github.com/MirrorNG/MirrorNG/issues/1251)) ([2f19c7c](MirageNet/Mirage@2f19c7c)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* hooks in host mode can call each other ([MirrorNetworking#1017](MirageNet/Mirage#1017)) ([f27fd0b](MirageNet/Mirage@f27fd0b))
* invalid scene id in 2019.1 by ignoring prefabs in NetworkScenePostProcess ([203a823](MirageNet/Mirage@203a823))
* isClient now reports true onStartServer in host mode ([MirrorNetworking#1252](https://github.com/MirrorNG/MirrorNG/issues/1252)) ([d00c95b](MirageNet/Mirage@d00c95b))
* isLocalPlayer is true during OnStartClient for Player ([MirrorNetworking#1255](https://github.com/MirrorNG/MirrorNG/issues/1255)) ([fb26d00](MirageNet/Mirage@fb26d00)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* isLocalPlayer works in host mode onStartServer ([MirrorNetworking#1253](https://github.com/MirrorNG/MirrorNG/issues/1253)) ([9acde20](MirageNet/Mirage@9acde20)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* it is not safe to modify this outside this class ([bc7a961](MirageNet/Mirage@bc7a961))
* list server logs properly when disconnected ([f02d317](MirageNet/Mirage@f02d317))
* ListServer Ping not found in WebGL ([6c4b34b](MirageNet/Mirage@6c4b34b))
* Lobby Remove button not showing for P1 when Server Only ([377c47c](MirageNet/Mirage@377c47c))
* maintain Unity's copyright notice ([MirrorNetworking#961](MirageNet/Mirage#961)) ([7718955](MirageNet/Mirage@7718955))
* Make assembly definition 2018.4 compatible ([99ecc9e](MirageNet/Mirage@99ecc9e))
* make build pass ([08df6d0](MirageNet/Mirage@08df6d0))
* Mark weaver as failed if serializing invalid type ([03c767d](MirageNet/Mirage@03c767d))
* missed ushort reader/writer ([74faf2a](MirageNet/Mirage@74faf2a))
* Mono.CecilX namespace to work around Unity 2019 Cecil namespace collision ([MirrorNetworking#832](MirageNet/Mirage#832)) ([5262592](MirageNet/Mirage@5262592))
* move listserver classes into package ([2668b17](MirageNet/Mirage@2668b17))
* move NetworkStreamExtension in a namespace ([12de543](MirageNet/Mirage@12de543))
* MultiplexTransport GetMaxMessageSize NullReferenceException when called on server. And fixes potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes. ([MirrorNetworking#1332](https://github.com/MirrorNG/MirrorNG/issues/1332)) ([b3127be](MirageNet/Mirage@b3127be))
* NetworkBehaviourInspector wouldn't show SyncMode if syncvars / syncobjects were only private ([ed572da](MirageNet/Mirage@ed572da))
* NetworkClient.Shutdown calls ClientScene.Shutdown again to properly clean up client scene. ClientScene only cleans up itself without touching transport or NetworkIdentities (fixes the bug where the player object wouldn't be destroyed after calling StopClient) ([fb716df](MirageNet/Mirage@fb716df))
* NetworkManager OnValidate wouldn't properly save the automatically added Transport before because Undo.RecordObject is needed for that now. ([524abfc](MirageNet/Mirage@524abfc))
* NetworkTransform clientAuthority works again via clientAuthority option that is configurable in inspector. this had to be fixed after we removed local authority. ([d712cd0](MirageNet/Mirage@d712cd0))
* non ready connections should not observe objects ([1352334](MirageNet/Mirage@1352334))
* null reference exception ([7ce95c5](MirageNet/Mirage@7ce95c5))
* OnClientReady is called and passed the appropriate ready state value in NetworkLobbyPlayer ([MirrorNetworking#618](MirageNet/Mirage#618)) ([c9eac57](MirageNet/Mirage@c9eac57))
* OnSetHostVisibility can now check if it has authority ([888e46c](MirageNet/Mirage@888e46c))
* pack works if message is boxed ([55c9bb6](MirageNet/Mirage@55c9bb6))
* Pass the name of the invoking class and desired command when an object has no authority. ([MirrorNetworking#1216](https://github.com/MirrorNG/MirrorNG/issues/1216)) ([701f4f4](MirageNet/Mirage@701f4f4))
* Potential DOS attack by sending invalid UTF8 byte sequences  ([MirrorNetworking#727](MirageNet/Mirage#727)) ([3cee3ab](MirageNet/Mirage@3cee3ab))
* Potential DOS attack on server by sending packed ulongs when packed uints are expected. ([MirrorNetworking#730](MirageNet/Mirage#730)) ([015d0d5](MirageNet/Mirage@015d0d5))
* potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes when using FallbackTransport. ([MirrorNetworking#1331](https://github.com/MirrorNG/MirrorNG/issues/1331)) ([5449840](MirageNet/Mirage@5449840))
* potential null reference exception with debug logging ([33493a0](MirageNet/Mirage@33493a0))
* Prevent Compiler Paradox ([MirrorNetworking#1145](MirageNet/Mirage#1145)) ([fd43c67](MirageNet/Mirage@fd43c67))
* properly stop client and server in OnApplicationQuit so that clients still get a chance to send then 'quit' packet instead of just timing out. Also fixes a bug where OnStopServer/OnStopClient were not called when stopping the Editor. ([MirrorNetworking#936](MirageNet/Mirage#936)) ([d6389e6](MirageNet/Mirage@d6389e6))
* Rebuild observers when we switch scenes, fixes [MirrorNetworking#978](MirageNet/Mirage#978) ([MirrorNetworking#1016](MirageNet/Mirage#1016)) ([6dd1350](MirageNet/Mirage@6dd1350))
* reduce allocations at the transport ([80e4f17](MirageNet/Mirage@80e4f17))
* release unitypackage ([MirrorNetworking#1355](https://github.com/MirrorNG/MirrorNG/issues/1355)) ([d0cc669](MirageNet/Mirage@d0cc669))
* remove samples from upm package ([MirrorNetworking#25](MirageNet/Mirage#25)) ([a71e21f](MirageNet/Mirage@a71e21f))
* replace player (remove authority by default) ([MirrorNetworking#1261](https://github.com/MirrorNG/MirrorNG/issues/1261)) ([ad724fe](MirageNet/Mirage@ad724fe)), closes [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257) [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257) [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257)
* ReplacePlayer now calls OnStartLocalPlayer ([MirrorNetworking#1280](https://github.com/MirrorNG/MirrorNG/issues/1280)) ([0e1bc81](MirageNet/Mirage@0e1bc81)), closes [MirrorNetworking#962](MirageNet/Mirage#962)
* replacing the player does not mean giving up authority ([MirrorNetworking#1254](https://github.com/MirrorNG/MirrorNG/issues/1254)) ([a2c273e](MirageNet/Mirage@a2c273e))
* Respect Player Prefab Position & Rotation ([MirrorNetworking#825](MirageNet/Mirage#825)) ([8ebda0f](MirageNet/Mirage@8ebda0f))
* Revert "NetworkClient.Shutdown: call ClientScene.Shutdown, otherwise it's never called" - caused client's player to not be removed from scene after disconnecting ([13bb748](MirageNet/Mirage@13bb748))
* Revert "NetworkIdentity.observers dictionary is always created, but always empty on clients. Gets rid of all null checks." to fix server-only bug not allowing movement on client, e.g. in uMMORPG ([f56507f](MirageNet/Mirage@f56507f))
* Revert "refactor:  consolidate prefab and spawn handlers ([MirrorNetworking#817](MirageNet/Mirage#817))" to fix a bug where if editor=host, build=client, we receive scene object not found when walking out of and back into an observer's range ([1f07af0](MirageNet/Mirage@1f07af0))
* Round Robin Spawning by Hierarchy Order ([MirrorNetworking#790](MirageNet/Mirage#790)) ([531e202](MirageNet/Mirage@531e202)), closes [MirrorNetworking#724](MirageNet/Mirage#724)
* SceneId was not set to 0 for prefab variants ([MirrorNetworking#976](MirageNet/Mirage#976)) ([MirrorNetworking#977](MirageNet/Mirage#977)) ([2ca2c48](MirageNet/Mirage@2ca2c48))
* set authority when replacing the player ([2195fee](MirageNet/Mirage@2195fee))
* Set syncvar variables after calling the hook ([MirrorNetworking#659](MirageNet/Mirage#659)) ([2d63ee1](MirageNet/Mirage@2d63ee1))
* set version number ([MirrorNetworking#1338](https://github.com/MirrorNG/MirrorNG/issues/1338)) ([0d1d7b5](MirageNet/Mirage@0d1d7b5))
* spawnwithauthority works again in host mode ([5b04836](MirageNet/Mirage@5b04836))
* Stop calling ClientDisconnect on host ([MirrorNetworking#597](MirageNet/Mirage#597)) ([b67b3e4](MirageNet/Mirage@b67b3e4))
* suppress warning on standalone build [MirrorNetworking#1053](MirageNet/Mirage#1053) ([4ef680a](MirageNet/Mirage@4ef680a))
* Suspend server transport while changing scenes ([MirrorNetworking#1169](MirageNet/Mirage#1169)) ([e8fac8a](MirageNet/Mirage@e8fac8a))
* Sync full netAnimator for new clients, fix [MirrorNetworking#980](MirageNet/Mirage#980) ([MirrorNetworking#1110](MirageNet/Mirage#1110)) ([db8310f](MirageNet/Mirage@db8310f))
* syncvars in commands work again ([MirrorNetworking#1131](MirageNet/Mirage#1131)) ([c24a73f](MirageNet/Mirage@c24a73f))
* TargetRpc now works accross assemblies ([MirrorNetworking#1130](MirageNet/Mirage#1130)) ([5ecd646](MirageNet/Mirage@5ecd646)), closes [MirrorNetworking#1128](MirageNet/Mirage#1128)
* Telepathy already supports IPv6, but can no also connect to IPv4-only servers again (e.g. Mirror Booster) ([488446a](MirageNet/Mirage@488446a))
* Telepathy fix a bug where calling Disconnect while connecting to a dead end would freeze Unity because .Join would wait forever. Interrupt fixes it. ([3831cbd](MirageNet/Mirage@3831cbd))
* Telepathy forgot to set socket options for accepted clients on the server ([22931fc](MirageNet/Mirage@22931fc))
* Telepathy updated to latest version (IPv6 fix again) ([535b4d4](MirageNet/Mirage@535b4d4))
* Telepathy updated to latest version (Send SocketExceptions now disconnect the player too) ([98d3fb0](MirageNet/Mirage@98d3fb0))
* Telepathy updated to latest version: Correctly support IPv4 and IPv6 sockets ([2761ff2](MirageNet/Mirage@2761ff2))
* Telepathy updated to latest version. connectionId counter is properly reset after stopping server. ([abf06df](MirageNet/Mirage@abf06df))
* TelepathyTransport.ToString UWP exception ([8a190bf](MirageNet/Mirage@8a190bf))
* Updated Telepathy to latest version to fix IPAddress.Parse error for "localhost" ([cc6e4f6](MirageNet/Mirage@cc6e4f6))
* version file ([MirrorNetworking#1337](https://github.com/MirrorNG/MirrorNG/issues/1337)) ([ed7e509](MirageNet/Mirage@ed7e509))
* webgl build fix [MirrorNetworking#1136](MirageNet/Mirage#1136) ([MirrorNetworking#1137](MirageNet/Mirage#1137)) ([c85d0df](MirageNet/Mirage@c85d0df))
* when modifying a prefab, Unity calls OnValidate for all scene objects based on that prefab, which caused Mirror to reset the sceneId because we only checked if a prefab is currently edited, not if THIS prefab is currently edited ([db99dd7](MirageNet/Mirage@db99dd7))
* **serialization:** Added NetworkWriter tests, found and fixed a bug in Write(Ray). ([MirrorNetworking#769](MirageNet/Mirage#769)) ([99c8f5c](MirageNet/Mirage@99c8f5c))
* **tests:** Added missing SyncListByteValid test file ([MirrorNetworking#634](MirageNet/Mirage#634)) ([b0af876](MirageNet/Mirage@b0af876))
* **weaver:** [MirrorNetworking#696](MirageNet/Mirage#696) detect .mystruct = new MyStruct() changes with syncvars ([MirrorNetworking#702](MirageNet/Mirage#702)) ([053949b](MirageNet/Mirage@053949b))
* **weaver:** fix [MirrorNetworking#706](MirageNet/Mirage#706) find system dlls ([MirrorNetworking#729](MirageNet/Mirage#729)) ([53be9b6](MirageNet/Mirage@53be9b6))
* **weaver:** fix [MirrorNetworking#796](MirageNet/Mirage#796), reload assemblies after initial import ([MirrorNetworking#1106](MirageNet/Mirage#1106)) ([d91b387](MirageNet/Mirage@d91b387))
* **websocket:** [MirrorNetworking#829](MirageNet/Mirage#829) fix InvalidOperationException with wss:// ([MirrorNetworking#830](MirageNet/Mirage#830)) ([2d682b5](MirageNet/Mirage@2d682b5))
* **websocket:** Remove send queues (they never worked) and SSL (temporarily) ([MirrorNetworking#879](MirageNet/Mirage#879)) ([3c60b08](MirageNet/Mirage@3c60b08))
* **websocket:** Use a buffer for most WS messages in WebGL client resulting in 0 alloc for most messages ([MirrorNetworking#848](MirageNet/Mirage#848)) ([8967a20](MirageNet/Mirage@8967a20))
* Telepathy updated to latest version: protect against allocation attacks via MaxMessageSize. Can be configured in the TelepathyTransport component now. ([67d715f](MirageNet/Mirage@67d715f))
* update NetworkIdentityEditor FindProperty to renamed variables ([a2cc14b](MirageNet/Mirage@a2cc14b))
* weaver Cmd/Rpc/Target prefix check is no longer trash ([MirrorNetworking#707](MirageNet/Mirage#707)) ([699a261](MirageNet/Mirage@699a261))
* workaround for [MirrorNetworking#791](MirageNet/Mirage#791) ([5c850aa](MirageNet/Mirage@5c850aa))

### Features

* [MirrorNetworking#869](MirageNet/Mirage#869) support structs in other assemblies ([MirrorNetworking#1022](MirageNet/Mirage#1022)) ([62d1887](MirageNet/Mirage@62d1887))
* Add roomPlayer parameter to OnRoomServerCreateGamePlayer ([MirrorNetworking#1317](https://github.com/MirrorNG/MirrorNG/issues/1317)) ([abf5cdc](MirageNet/Mirage@abf5cdc))
* Add SyncHashSet and SyncSortedSet ([MirrorNetworking#685](MirageNet/Mirage#685)) ([695979e](MirageNet/Mirage@695979e))
* Add Timeout to NetworkAuthenticator ([MirrorNetworking#1091](MirageNet/Mirage#1091)) ([e8cc9ba](MirageNet/Mirage@e8cc9ba))
* Add UPM configuration ([MirrorNetworking#11](MirageNet/Mirage#11)) ([9280af1](MirageNet/Mirage@9280af1))
* Add version to package file ([MirrorNetworking#1361](https://github.com/MirrorNG/MirrorNG/issues/1361)) ([e97ab93](MirageNet/Mirage@e97ab93))
* Add weaver support for Vector2Int and Vector3Int ([MirrorNetworking#646](MirageNet/Mirage#646)) ([e2a6ce9](MirageNet/Mirage@e2a6ce9))
* allow users to detect mirror version 3 ([ee9c737](MirageNet/Mirage@ee9c737))
* An authenticator that times out other authenticators ([MirrorNetworking#1211](https://github.com/MirrorNG/MirrorNG/issues/1211)) ([09f6892](MirageNet/Mirage@09f6892))
* Authentication Framework ([MirrorNetworking#1057](MirageNet/Mirage#1057)) ([56bcb02](MirageNet/Mirage@56bcb02))
* Chat example ([MirrorNetworking#1305](https://github.com/MirrorNG/MirrorNG/issues/1305)) ([9926472](MirageNet/Mirage@9926472))
* component based SyncToOwner, fixes [MirrorNetworking#39](MirageNet/Mirage#39) ([MirrorNetworking#1023](MirageNet/Mirage#1023)) ([c6d86b3](MirageNet/Mirage@c6d86b3))
* custom reader/writer via extension methods ([MirrorNetworking#1047](MirageNet/Mirage#1047)) ([b45afad](MirageNet/Mirage@b45afad))
* Custom readers and writers ([92b3e98](MirageNet/Mirage@92b3e98))
* fallback transport now supports uri ([MirrorNetworking#1296](https://github.com/MirrorNG/MirrorNG/issues/1296)) ([e4a701e](MirageNet/Mirage@e4a701e))
* generate serializers for IMessageBase structs ([MirrorNetworking#1353](https://github.com/MirrorNG/MirrorNG/issues/1353)) ([3c0bc28](MirageNet/Mirage@3c0bc28))
* Implement IReadOnlyList<T> in SyncLists ([MirrorNetworking#903](MirageNet/Mirage#903)) ([3eaaa77](MirageNet/Mirage@3eaaa77))
* Include version in release ([MirrorNetworking#1336](https://github.com/MirrorNG/MirrorNG/issues/1336)) ([e4f89cf](MirageNet/Mirage@e4f89cf))
* LLAPI transport can receive port from uri ([MirrorNetworking#1294](https://github.com/MirrorNG/MirrorNG/issues/1294)) ([7865a84](MirageNet/Mirage@7865a84))
* Mirror now supports message inheritance ([MirrorNetworking#1286](https://github.com/MirrorNG/MirrorNG/issues/1286)) ([f9d34d5](MirageNet/Mirage@f9d34d5))
* Multiplex based on url ([MirrorNetworking#1295](https://github.com/MirrorNG/MirrorNG/issues/1295)) ([c206f9a](MirageNet/Mirage@c206f9a))
* network writer pool to avoid expensive allocations ([3659acb](MirageNet/Mirage@3659acb))
* network writer pool to avoid expensive allocations ([MirrorNetworking#928](MirageNet/Mirage#928)) ([f5e9318](MirageNet/Mirage@f5e9318))
* NetworkConnection is optional for handlers ([MirrorNetworking#1202](https://github.com/MirrorNG/MirrorNG/issues/1202)) ([bf9eb61](MirageNet/Mirage@bf9eb61))
* new way to connect using uri ([MirrorNetworking#1279](https://github.com/MirrorNG/MirrorNG/issues/1279)) ([7c3622c](MirageNet/Mirage@7c3622c))
* Pass all information to spawn handler ([MirrorNetworking#1215](https://github.com/MirrorNG/MirrorNG/issues/1215)) ([d741bae](MirageNet/Mirage@d741bae))
* profiler info is available in production builds ([5649cc6](MirageNet/Mirage@5649cc6))
* Remove Command shortcut for host mode ([MirrorNetworking#1168](MirageNet/Mirage#1168)) ([94eda38](MirageNet/Mirage@94eda38))
* safer and consistent writers names ([MirrorNetworking#979](MirageNet/Mirage#979)) ([b4077c1](MirageNet/Mirage@b4077c1))
* Script Templates ([MirrorNetworking#1217](https://github.com/MirrorNG/MirrorNG/issues/1217)) ([8cf6a07](MirageNet/Mirage@8cf6a07))
* Secure messages that require authentication, fixes [MirrorNetworking#720](MirageNet/Mirage#720) ([MirrorNetworking#1089](MirageNet/Mirage#1089)) ([7ac43cd](MirageNet/Mirage@7ac43cd))
* Semantic release for UPM ([MirrorNetworking#24](MirageNet/Mirage#24)) ([8cbc005](MirageNet/Mirage@8cbc005))
* ship as a unitypackage ([11edc14](MirageNet/Mirage@11edc14))
* Show compile time error if overriding unused OnServerAddPlayer ([MirrorNetworking#682](MirageNet/Mirage#682)) ([a8599c1](MirageNet/Mirage@a8599c1))
* support sending and receiving ArraySegment<byte> ([MirrorNetworking#898](MirageNet/Mirage#898)) ([e5eecbf](MirageNet/Mirage@e5eecbf))
* support writing and reading array segments ([MirrorNetworking#918](MirageNet/Mirage#918)) ([f9ff443](MirageNet/Mirage@f9ff443))
* SyncDictionary can now be used for any IDictionary ([MirrorNetworking#703](MirageNet/Mirage#703)) ([2683572](MirageNet/Mirage@2683572))
* SyncList now supports any IList implementation ([MirrorNetworking#704](MirageNet/Mirage#704)) ([040bcb4](MirageNet/Mirage@040bcb4))
* SyncList.FindIndex added ([MirrorNetworking#823](MirageNet/Mirage#823)) ([b5ff43a](MirageNet/Mirage@b5ff43a))
* SyncSet custom Equality Comparer support ([MirrorNetworking#1147](MirageNet/Mirage#1147)) ([0f95185](MirageNet/Mirage@0f95185))
* SyncToOwner now works with authority ([MirrorNetworking#1204](https://github.com/MirrorNG/MirrorNG/issues/1204)) ([92d0df7](MirageNet/Mirage@92d0df7))
* telepathy can now receive port from uri ([MirrorNetworking#1284](https://github.com/MirrorNG/MirrorNG/issues/1284)) ([06946cf](MirageNet/Mirage@06946cf))
* Transport can send to multiple connections at once ([MirrorNetworking#1120](MirageNet/Mirage#1120)) ([bc7e116](MirageNet/Mirage@bc7e116))
* update upm package if tests pass ([MirrorNetworking#21](MirageNet/Mirage#21)) ([7447776](MirageNet/Mirage@7447776))
* user friendly weaver error ([MirrorNetworking#896](MirageNet/Mirage#896)) ([954a3d5](MirageNet/Mirage@954a3d5))
* Users may provide custom serializers for any type ([MirrorNetworking#1153](MirageNet/Mirage#1153)) ([9cb309e](MirageNet/Mirage@9cb309e))
* websocket can receive port in url ([MirrorNetworking#1287](https://github.com/MirrorNG/MirrorNG/issues/1287)) ([c8ad118](MirageNet/Mirage@c8ad118))
* Websockets now give client address, fix [MirrorNetworking#1121](MirageNet/Mirage#1121) ([MirrorNetworking#1125](MirageNet/Mirage#1125)) ([c9f317d](MirageNet/Mirage@c9f317d))
* **scene:** Add support for scene loading params ([MirrorNetworking#644](MirageNet/Mirage#644)) ([d48a375](MirageNet/Mirage@d48a375))
* **syncvar:** Add SyncDictionary ([MirrorNetworking#602](MirageNet/Mirage#602)) ([7d21bde](MirageNet/Mirage@7d21bde))
* **telepathy:** Split MaxMessageSize to allow setting a different value for client and server ([MirrorNetworking#749](MirageNet/Mirage#749)) ([f0a8b5d](MirageNet/Mirage@f0a8b5d))
* **websocket:** Re-enable native SSL ([MirrorNetworking#965](MirageNet/Mirage#965)) ([7ed4a9a](MirageNet/Mirage@7ed4a9a))

### Performance Improvements

* AddPlayerMessage is now a value type ([246a551](MirageNet/Mirage@246a551))
* allocation free enumerator for syncsets,  fixes [MirrorNetworking#1171](MirageNet/Mirage#1171) ([MirrorNetworking#1173](MirageNet/Mirage#1173)) ([035e630](MirageNet/Mirage@035e630))
* allocation free syncdict foreach, fix [MirrorNetworking#1172](MirageNet/Mirage#1172) ([MirrorNetworking#1174](MirageNet/Mirage#1174)) ([1ec8910](MirageNet/Mirage@1ec8910))
* avoid allocation for error messages ([c669ff1](MirageNet/Mirage@c669ff1))
* Avoid allocation when reading message payload ([MirrorNetworking#912](MirageNet/Mirage#912)) ([11750a9](MirageNet/Mirage@11750a9))
* avoid allocation with message structs ([MirrorNetworking#939](MirageNet/Mirage#939)) ([7c7c910](MirageNet/Mirage@7c7c910))
* avoid boxing for getting message id ([MirrorNetworking#1144](MirageNet/Mirage#1144)) ([9513842](MirageNet/Mirage@9513842))
* avoid boxing if there is no profiler ([a351879](MirageNet/Mirage@a351879))
* ClientAuthorityMessage is now a value type ([MirrorNetworking#991](MirageNet/Mirage#991)) ([d071438](MirageNet/Mirage@d071438))
* Custom IEnumerator for SyncLists to avoid allocations on foreach ([MirrorNetworking#904](MirageNet/Mirage#904)) ([4ffd5a2](MirageNet/Mirage@4ffd5a2))
* don't varint bytes and shorts ([4867415](MirageNet/Mirage@4867415))
* eliminate boxing with lists ([MirrorNetworking#901](MirageNet/Mirage#901)) ([8f6d4cb](MirageNet/Mirage@8f6d4cb))
* eliminate small allocation on remote calls ([MirrorNetworking#907](MirageNet/Mirage#907)) ([1c18743](MirageNet/Mirage@1c18743))
* eliminate string concat during remote method calls ([MirrorNetworking#908](MirageNet/Mirage#908)) ([70a532b](MirageNet/Mirage@70a532b))
* empty messages are value types now ([145edaa](MirageNet/Mirage@145edaa))
* messages should be value types ([MirrorNetworking#987](MirageNet/Mirage#987)) ([633fb19](MirageNet/Mirage@633fb19))
* MultiplexTransport: avoid Linq allocations that would happen on every packet send because Send calls .ServerActive() each time ([7fe8888](MirageNet/Mirage@7fe8888))
* Networkreader nonalloc ([MirrorNetworking#910](MirageNet/Mirage#910)) ([18f035d](MirageNet/Mirage@18f035d))
* objdestroy message is now a value type ([MirrorNetworking#993](MirageNet/Mirage#993)) ([a32c5a9](MirageNet/Mirage@a32c5a9))
* ObjHideMessage is now a value type ([MirrorNetworking#992](MirageNet/Mirage#992)) ([a49d938](MirageNet/Mirage@a49d938))
* OnDeserializeSafely without GC ([MirrorNetworking#804](MirageNet/Mirage#804)) ([27b7e25](MirageNet/Mirage@27b7e25))
* Optimize interest management ([f1ceb0c](MirageNet/Mirage@f1ceb0c))
* Optimize interest management ([MirrorNetworking#899](MirageNet/Mirage#899)) ([ff1a234](MirageNet/Mirage@ff1a234))
* Pack small 32 bit negatives efficiently ([480af1a](MirageNet/Mirage@480af1a))
* Pack small 64 bit negatives efficiently ([5f1ef4a](MirageNet/Mirage@5f1ef4a))
* Recycle argument writer to avoid allocations ([MirrorNetworking#945](MirageNet/Mirage#945)) ([9743216](MirageNet/Mirage@9743216))
* Reduce enum bandwidth ([MirrorNetworking#794](MirageNet/Mirage#794)) ([97e9ac2](MirageNet/Mirage@97e9ac2))
* remove allocations during syncvar sync ([MirrorNetworking#946](MirageNet/Mirage#946)) ([d2381ce](MirageNet/Mirage@d2381ce))
* remove BinaryWriter,  it allocates like crazy ([MirrorNetworking#929](MirageNet/Mirage#929)) ([7b3e82a](MirageNet/Mirage@7b3e82a))
* remove network transform allocation ([9e3ecc1](MirageNet/Mirage@9e3ecc1))
* remove syncvar boxing ([MirrorNetworking#927](MirageNet/Mirage#927)) ([b2ba589](MirageNet/Mirage@b2ba589))
* return the contents of the writer as an array segment ([MirrorNetworking#916](MirageNet/Mirage#916)) ([ced3690](MirageNet/Mirage@ced3690))
* reuse the network writer used for rpc parameters ([5dafc4d](MirageNet/Mirage@5dafc4d))
* rpc messages are now value types ([MirrorNetworking#997](MirageNet/Mirage#997)) ([b5b2f3e](MirageNet/Mirage@b5b2f3e))
* SceneMessage is now a value type ([MirrorNetworking#989](MirageNet/Mirage#989)) ([407b36a](MirageNet/Mirage@407b36a))
* spawn with client authority only takes 1 message ([MirrorNetworking#1206](https://github.com/MirrorNG/MirrorNG/issues/1206)) ([3b9414f](MirageNet/Mirage@3b9414f))
* SpawnPrefabMessage is now a value type ([a44efd1](MirageNet/Mirage@a44efd1))
* SpawnSceneObjectMessage is now a value type ([40c7d97](MirageNet/Mirage@40c7d97))
* Transports now give ArraySegment<byte> instead of byte[] (based on [MirrorNetworking#569](MirageNet/Mirage#569) and [MirrorNetworking#846](MirageNet/Mirage#846)) ([77bee45](MirageNet/Mirage@77bee45))
* update vars is now a value type ([MirrorNetworking#990](MirageNet/Mirage#990)) ([f99e71e](MirageNet/Mirage@f99e71e))
* Use 0 for null byte arrays ([MirrorNetworking#925](MirageNet/Mirage#925)) ([21ca49d](MirageNet/Mirage@21ca49d))
* use 0 for null strings ([MirrorNetworking#926](MirageNet/Mirage#926)) ([7181cd9](MirageNet/Mirage@7181cd9))
* use bitshift operations instead of division in varint ([fff765c](MirageNet/Mirage@fff765c))
* Use RemoveAt to remove elements from lists ([22b45f7](MirageNet/Mirage@22b45f7))
* use value types for empty messages ([MirrorNetworking#988](MirageNet/Mirage#988)) ([81d915e](MirageNet/Mirage@81d915e))
* Use WritePackedUInt32 in SyncList ([MirrorNetworking#688](MirageNet/Mirage#688)) ([2db7576](MirageNet/Mirage@2db7576))

* Merge pull request MirrorNetworking#650 from vis2k/networkclient_static_2 ([fac0542](MirageNet/Mirage@fac0542)), closes [MirrorNetworking#650](MirageNet/Mirage#650)

### BREAKING CHANGES

* Remove obsolete OnServerAddPlayer

Any person that overrides this method has a broken game.  These methods are never called anywhere.

The user gets a warning because they are overriding an obsolete method,  which might get ignored if they have lots of other warnings.   They would run their game and their game would not work at all.  No errors.

By removing these methods, users that override these methods will get a compile time error instead.  So they cannot ignore this error and they will fix it.

* Method is no longer available in NetworkLobbyManager
* Make NetworkClient Great Again!
Lymdun pushed a commit to Lymdun/Mirror that referenced this issue Jan 17, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
52d21b3 
# 1.0.0 (2020-01-04)

### Bug Fixes

* (again) Telepathy updated to latest version (Send SocketExceptions now disconnect the player too) ([46eddc0](MirageNet/Mirage@46eddc0))
* [MirrorNetworking#1359](https://github.com/MirrorNG/MirrorNG/issues/1359). Revert "Destroy objects owned by this connection when disconnecting ([MirrorNetworking#1179](https://github.com/MirrorNG/MirrorNG/issues/1179))" ([4cc4279](MirageNet/Mirage@4cc4279))
* [MirrorNetworking#573](MirageNet/Mirage#573) (part 1) NetworkScenePostProcess handles NetworkIdentities of all scenes except DontDestroyOnLoad. this way it works for additively loaded scenes too. ([c1af84e](MirageNet/Mirage@c1af84e))
* [MirrorNetworking#573](MirageNet/Mirage#573) (part 2) NetworkManager detects additive scene loads and respawns objects on server/client again ([e521a20](MirageNet/Mirage@e521a20))
* [MirrorNetworking#573](MirageNet/Mirage#573) NullReferenceException because destroyed NetworkIdentities were never removed from sceneIds dict ([a2d6317](MirageNet/Mirage@a2d6317))
* [MirrorNetworking#609](MirageNet/Mirage#609) by spawning observers in NetworkServer.AddPlayerForConnection after setting the controller. There is no point in trying to spawn with a null controller in SetReady, because by definition no one can observer something that is null. ([MirrorNetworking#623](MirageNet/Mirage#623)) ([5c00577](MirageNet/Mirage@5c00577))
* [MirrorNetworking#640](MirageNet/Mirage#640) InternalReplacePlayerForConnection calls SpawnObserversForConnection now too ([bdf12c8](MirageNet/Mirage@bdf12c8))
* [MirrorNetworking#651](MirageNet/Mirage#651) GetSceneAt assumes default scene ([MirrorNetworking#654](MirageNet/Mirage#654)) ([65eaba1](MirageNet/Mirage@65eaba1))
* [MirrorNetworking#652](MirageNet/Mirage#652) OnPostProcessScene includes disabled NetworkIdentities in scene ([ee2ace8](MirageNet/Mirage@ee2ace8))
* [MirrorNetworking#679](MirageNet/Mirage#679) package for unity ([4a6a4df](MirageNet/Mirage@4a6a4df))
* [MirrorNetworking#679](MirageNet/Mirage#679) unity package ([9895647](MirageNet/Mirage@9895647))
* [MirrorNetworking#692](MirageNet/Mirage#692) by always adding connectionToClient when rebuilding observers ([ab44ac8](MirageNet/Mirage@ab44ac8))
* [MirrorNetworking#718](MirageNet/Mirage#718) remove Tests folder from unitypackage ([MirrorNetworking#827](MirageNet/Mirage#827)) ([7e487af](MirageNet/Mirage@7e487af))
* [MirrorNetworking#791](MirageNet/Mirage#791) corrected assembly paths passed to weaver ([MirrorNetworking#803](MirageNet/Mirage#803)) ([3ba546e](MirageNet/Mirage@3ba546e))
* [MirrorNetworking#791](MirageNet/Mirage#791) stack overflow in the weaver ([MirrorNetworking#792](MirageNet/Mirage#792)) ([7b57830](MirageNet/Mirage@7b57830))
* [MirrorNetworking#840](MirageNet/Mirage#840) by allowing Mirror to respect the forceHidden flag ([MirrorNetworking#893](MirageNet/Mirage#893)) ([3ec3d02](MirageNet/Mirage@3ec3d02))
* added new read/write symbol params ([MirrorNetworking#806](MirageNet/Mirage#806)) ([3a50ca6](MirageNet/Mirage@3a50ca6))
* Added WriteBytesAndSize tests, and fixed the function to be pedantic. ([MirrorNetworking#773](MirageNet/Mirage#773)) ([72e4e55](MirageNet/Mirage@72e4e55))
* Additive scene can respawn objects safely ([MirrorNetworking#1270](https://github.com/MirrorNG/MirrorNG/issues/1270)) ([8899d20](MirageNet/Mirage@8899d20))
* ArraySegment<byte> work in Messages ([MirrorNetworking#919](MirageNet/Mirage#919)) ([981ba7c](MirageNet/Mirage@981ba7c))
* Call hooks when initializing objects OnStartServer on host ([MirrorNetworking#1249](https://github.com/MirrorNG/MirrorNG/issues/1249)) ([7aa7815](MirageNet/Mirage@7aa7815))
* call Obsoleted OnStartClient ([MirrorNetworking#681](MirageNet/Mirage#681)) ([8dea50e](MirageNet/Mirage@8dea50e))
* call OnStartClient only once in room ([MirrorNetworking#1264](https://github.com/MirrorNG/MirrorNG/issues/1264)) ([4d373c5](MirageNet/Mirage@4d373c5))
* check event prefix ([7417b68](MirageNet/Mirage@7417b68))
* ClientRpc methods now work accross assemblies ([MirrorNetworking#1129](MirageNet/Mirage#1129)) ([13dbcb9](MirageNet/Mirage@13dbcb9)), closes [MirrorNetworking#1128](MirageNet/Mirage#1128)
* Cmds can be called from child classes in other assemblies ([d8a98d8](MirageNet/Mirage@d8a98d8)), closes [MirrorNetworking#1108](MirageNet/Mirage#1108)
* code generation works with il2cpp again ([MirrorNetworking#1056](MirageNet/Mirage#1056)) ([8738562](MirageNet/Mirage@8738562))
* destroy owned objects ([MirrorNetworking#1352](https://github.com/MirrorNG/MirrorNG/issues/1352)) ([d7a58d2](MirageNet/Mirage@d7a58d2)), closes [MirrorNetworking#1346](https://github.com/MirrorNG/MirrorNG/issues/1346) [MirrorNetworking#1206](https://github.com/MirrorNG/MirrorNG/issues/1206) [MirrorNetworking#1351](https://github.com/MirrorNG/MirrorNG/issues/1351)
* do not accumulate changes if there are no observers fixes [MirrorNetworking#963](MirageNet/Mirage#963) ([MirrorNetworking#964](MirageNet/Mirage#964)) ([64a0468](MirageNet/Mirage@64a0468))
* Do not call InternalAddPlayer twice ([MirrorNetworking#1246](https://github.com/MirrorNG/MirrorNG/issues/1246)) ([7119dd1](MirageNet/Mirage@7119dd1))
* don't call hook in host if no change,  fixes [MirrorNetworking#1142](MirageNet/Mirage#1142) ([MirrorNetworking#1143](MirageNet/Mirage#1143)) ([d8ce80f](MirageNet/Mirage@d8ce80f))
* don't convert null arrays to empty array ([MirrorNetworking#913](MirageNet/Mirage#913)) ([dd758ca](MirageNet/Mirage@dd758ca))
* Don't disconnect host ([MirrorNetworking#608](MirageNet/Mirage#608)) ([c1707e5](MirageNet/Mirage@c1707e5))
* Don't give host player authority by default ([MirrorNetworking#1158](MirageNet/Mirage#1158)) ([1fc1ed2](MirageNet/Mirage@1fc1ed2))
* Don't increment counter in Awake ([MirrorNetworking#971](MirageNet/Mirage#971)) ([45b7118](MirageNet/Mirage@45b7118))
* Don't set asset id for scene objects ([7e40232](MirageNet/Mirage@7e40232))
* Don't set framerate in host mode ([4644bc4](MirageNet/Mirage@4644bc4))
* Don't throw exception getting address ([7df3ce3](MirageNet/Mirage@7df3ce3))
* don't use obsolete method ([12437ba](MirageNet/Mirage@12437ba))
* Draw SyncVar label for Unity objects inline  ([MirrorNetworking#1291](https://github.com/MirrorNG/MirrorNG/issues/1291)) ([a0425e4](MirageNet/Mirage@a0425e4))
* Dummy file for SyncListStructProcessor.cs ([MirrorNetworking#798](MirageNet/Mirage#798)) ([75e4f15](MirageNet/Mirage@75e4f15))
* error when there are no network behaviors ([MirrorNetworking#1303](https://github.com/MirrorNG/MirrorNG/issues/1303)) ([dbe0643](MirageNet/Mirage@dbe0643))
* error with missing assemblies ([MirrorNetworking#1052](MirageNet/Mirage#1052)) ([00eb23a](MirageNet/Mirage@00eb23a)), closes [MirrorNetworking#1051](MirageNet/Mirage#1051)
* Fix error scene error message in host mode ([838d4f0](MirageNet/Mirage@838d4f0))
* hasAuthority is now visible in all overrides ([MirrorNetworking#1251](https://github.com/MirrorNG/MirrorNG/issues/1251)) ([2f19c7c](MirageNet/Mirage@2f19c7c)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* hooks in host mode can call each other ([MirrorNetworking#1017](MirageNet/Mirage#1017)) ([f27fd0b](MirageNet/Mirage@f27fd0b))
* invalid scene id in 2019.1 by ignoring prefabs in NetworkScenePostProcess ([203a823](MirageNet/Mirage@203a823))
* isClient now reports true onStartServer in host mode ([MirrorNetworking#1252](https://github.com/MirrorNG/MirrorNG/issues/1252)) ([d00c95b](MirageNet/Mirage@d00c95b))
* isLocalPlayer is true during OnStartClient for Player ([MirrorNetworking#1255](https://github.com/MirrorNG/MirrorNG/issues/1255)) ([fb26d00](MirageNet/Mirage@fb26d00)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* isLocalPlayer works in host mode onStartServer ([MirrorNetworking#1253](https://github.com/MirrorNG/MirrorNG/issues/1253)) ([9acde20](MirageNet/Mirage@9acde20)), closes [MirrorNetworking#1250](https://github.com/MirrorNG/MirrorNG/issues/1250)
* it is not safe to modify this outside this class ([bc7a961](MirageNet/Mirage@bc7a961))
* list server logs properly when disconnected ([f02d317](MirageNet/Mirage@f02d317))
* ListServer Ping not found in WebGL ([6c4b34b](MirageNet/Mirage@6c4b34b))
* Lobby Remove button not showing for P1 when Server Only ([377c47c](MirageNet/Mirage@377c47c))
* maintain Unity's copyright notice ([MirrorNetworking#961](MirageNet/Mirage#961)) ([7718955](MirageNet/Mirage@7718955))
* Make assembly definition 2018.4 compatible ([99ecc9e](MirageNet/Mirage@99ecc9e))
* make build pass ([08df6d0](MirageNet/Mirage@08df6d0))
* Mark weaver as failed if serializing invalid type ([03c767d](MirageNet/Mirage@03c767d))
* missed ushort reader/writer ([74faf2a](MirageNet/Mirage@74faf2a))
* Mono.CecilX namespace to work around Unity 2019 Cecil namespace collision ([MirrorNetworking#832](MirageNet/Mirage#832)) ([5262592](MirageNet/Mirage@5262592))
* move listserver classes into package ([2668b17](MirageNet/Mirage@2668b17))
* move NetworkStreamExtension in a namespace ([12de543](MirageNet/Mirage@12de543))
* MultiplexTransport GetMaxMessageSize NullReferenceException when called on server. And fixes potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes. ([MirrorNetworking#1332](https://github.com/MirrorNG/MirrorNG/issues/1332)) ([b3127be](MirageNet/Mirage@b3127be))
* NetworkBehaviourInspector wouldn't show SyncMode if syncvars / syncobjects were only private ([ed572da](MirageNet/Mirage@ed572da))
* NetworkClient.Shutdown calls ClientScene.Shutdown again to properly clean up client scene. ClientScene only cleans up itself without touching transport or NetworkIdentities (fixes the bug where the player object wouldn't be destroyed after calling StopClient) ([fb716df](MirageNet/Mirage@fb716df))
* NetworkManager OnValidate wouldn't properly save the automatically added Transport before because Undo.RecordObject is needed for that now. ([524abfc](MirageNet/Mirage@524abfc))
* NetworkTransform clientAuthority works again via clientAuthority option that is configurable in inspector. this had to be fixed after we removed local authority. ([d712cd0](MirageNet/Mirage@d712cd0))
* non ready connections should not observe objects ([1352334](MirageNet/Mirage@1352334))
* null reference exception ([7ce95c5](MirageNet/Mirage@7ce95c5))
* OnClientReady is called and passed the appropriate ready state value in NetworkLobbyPlayer ([MirrorNetworking#618](MirageNet/Mirage#618)) ([c9eac57](MirageNet/Mirage@c9eac57))
* OnSetHostVisibility can now check if it has authority ([888e46c](MirageNet/Mirage@888e46c))
* pack works if message is boxed ([55c9bb6](MirageNet/Mirage@55c9bb6))
* Pass the name of the invoking class and desired command when an object has no authority. ([MirrorNetworking#1216](https://github.com/MirrorNG/MirrorNG/issues/1216)) ([701f4f4](MirageNet/Mirage@701f4f4))
* Potential DOS attack by sending invalid UTF8 byte sequences  ([MirrorNetworking#727](MirageNet/Mirage#727)) ([3cee3ab](MirageNet/Mirage@3cee3ab))
* Potential DOS attack on server by sending packed ulongs when packed uints are expected. ([MirrorNetworking#730](MirageNet/Mirage#730)) ([015d0d5](MirageNet/Mirage@015d0d5))
* potential exploits / out of sync issues where clients with different transports might see different game states because of different max message sizes when using FallbackTransport. ([MirrorNetworking#1331](https://github.com/MirrorNG/MirrorNG/issues/1331)) ([5449840](MirageNet/Mirage@5449840))
* potential null reference exception with debug logging ([33493a0](MirageNet/Mirage@33493a0))
* Prevent Compiler Paradox ([MirrorNetworking#1145](MirageNet/Mirage#1145)) ([fd43c67](MirageNet/Mirage@fd43c67))
* properly stop client and server in OnApplicationQuit so that clients still get a chance to send then 'quit' packet instead of just timing out. Also fixes a bug where OnStopServer/OnStopClient were not called when stopping the Editor. ([MirrorNetworking#936](MirageNet/Mirage#936)) ([d6389e6](MirageNet/Mirage@d6389e6))
* Rebuild observers when we switch scenes, fixes [MirrorNetworking#978](MirageNet/Mirage#978) ([MirrorNetworking#1016](MirageNet/Mirage#1016)) ([6dd1350](MirageNet/Mirage@6dd1350))
* reduce allocations at the transport ([80e4f17](MirageNet/Mirage@80e4f17))
* release unitypackage ([MirrorNetworking#1355](https://github.com/MirrorNG/MirrorNG/issues/1355)) ([d0cc669](MirageNet/Mirage@d0cc669))
* remove samples from upm package ([MirrorNetworking#25](MirageNet/Mirage#25)) ([a71e21f](MirageNet/Mirage@a71e21f))
* replace player (remove authority by default) ([MirrorNetworking#1261](https://github.com/MirrorNG/MirrorNG/issues/1261)) ([ad724fe](MirageNet/Mirage@ad724fe)), closes [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257) [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257) [MirrorNetworking#1257](https://github.com/MirrorNG/MirrorNG/issues/1257)
* ReplacePlayer now calls OnStartLocalPlayer ([MirrorNetworking#1280](https://github.com/MirrorNG/MirrorNG/issues/1280)) ([0e1bc81](MirageNet/Mirage@0e1bc81)), closes [MirrorNetworking#962](MirageNet/Mirage#962)
* replacing the player does not mean giving up authority ([MirrorNetworking#1254](https://github.com/MirrorNG/MirrorNG/issues/1254)) ([a2c273e](MirageNet/Mirage@a2c273e))
* Respect Player Prefab Position & Rotation ([MirrorNetworking#825](MirageNet/Mirage#825)) ([8ebda0f](MirageNet/Mirage@8ebda0f))
* Revert "NetworkClient.Shutdown: call ClientScene.Shutdown, otherwise it's never called" - caused client's player to not be removed from scene after disconnecting ([13bb748](MirageNet/Mirage@13bb748))
* Revert "NetworkIdentity.observers dictionary is always created, but always empty on clients. Gets rid of all null checks." to fix server-only bug not allowing movement on client, e.g. in uMMORPG ([f56507f](MirageNet/Mirage@f56507f))
* Revert "refactor:  consolidate prefab and spawn handlers ([MirrorNetworking#817](MirageNet/Mirage#817))" to fix a bug where if editor=host, build=client, we receive scene object not found when walking out of and back into an observer's range ([1f07af0](MirageNet/Mirage@1f07af0))
* Round Robin Spawning by Hierarchy Order ([MirrorNetworking#790](MirageNet/Mirage#790)) ([531e202](MirageNet/Mirage@531e202)), closes [MirrorNetworking#724](MirageNet/Mirage#724)
* SceneId was not set to 0 for prefab variants ([MirrorNetworking#976](MirageNet/Mirage#976)) ([MirrorNetworking#977](MirageNet/Mirage#977)) ([2ca2c48](MirageNet/Mirage@2ca2c48))
* set authority when replacing the player ([2195fee](MirageNet/Mirage@2195fee))
* Set syncvar variables after calling the hook ([MirrorNetworking#659](MirageNet/Mirage#659)) ([2d63ee1](MirageNet/Mirage@2d63ee1))
* set version number ([MirrorNetworking#1338](https://github.com/MirrorNG/MirrorNG/issues/1338)) ([0d1d7b5](MirageNet/Mirage@0d1d7b5))
* spawnwithauthority works again in host mode ([5b04836](MirageNet/Mirage@5b04836))
* Stop calling ClientDisconnect on host ([MirrorNetworking#597](MirageNet/Mirage#597)) ([b67b3e4](MirageNet/Mirage@b67b3e4))
* suppress warning on standalone build [MirrorNetworking#1053](MirageNet/Mirage#1053) ([4ef680a](MirageNet/Mirage@4ef680a))
* Suspend server transport while changing scenes ([MirrorNetworking#1169](MirageNet/Mirage#1169)) ([e8fac8a](MirageNet/Mirage@e8fac8a))
* Sync full netAnimator for new clients, fix [MirrorNetworking#980](MirageNet/Mirage#980) ([MirrorNetworking#1110](MirageNet/Mirage#1110)) ([db8310f](MirageNet/Mirage@db8310f))
* syncvars in commands work again ([MirrorNetworking#1131](MirageNet/Mirage#1131)) ([c24a73f](MirageNet/Mirage@c24a73f))
* TargetRpc now works accross assemblies ([MirrorNetworking#1130](MirageNet/Mirage#1130)) ([5ecd646](MirageNet/Mirage@5ecd646)), closes [MirrorNetworking#1128](MirageNet/Mirage#1128)
* Telepathy already supports IPv6, but can no also connect to IPv4-only servers again (e.g. Mirror Booster) ([488446a](MirageNet/Mirage@488446a))
* Telepathy fix a bug where calling Disconnect while connecting to a dead end would freeze Unity because .Join would wait forever. Interrupt fixes it. ([3831cbd](MirageNet/Mirage@3831cbd))
* Telepathy forgot to set socket options for accepted clients on the server ([22931fc](MirageNet/Mirage@22931fc))
* Telepathy updated to latest version (IPv6 fix again) ([535b4d4](MirageNet/Mirage@535b4d4))
* Telepathy updated to latest version (Send SocketExceptions now disconnect the player too) ([98d3fb0](MirageNet/Mirage@98d3fb0))
* Telepathy updated to latest version: Correctly support IPv4 and IPv6 sockets ([2761ff2](MirageNet/Mirage@2761ff2))
* Telepathy updated to latest version. connectionId counter is properly reset after stopping server. ([abf06df](MirageNet/Mirage@abf06df))
* TelepathyTransport.ToString UWP exception ([8a190bf](MirageNet/Mirage@8a190bf))
* Updated Telepathy to latest version to fix IPAddress.Parse error for "localhost" ([cc6e4f6](MirageNet/Mirage@cc6e4f6))
* version file ([MirrorNetworking#1337](https://github.com/MirrorNG/MirrorNG/issues/1337)) ([ed7e509](MirageNet/Mirage@ed7e509))
* webgl build fix [MirrorNetworking#1136](MirageNet/Mirage#1136) ([MirrorNetworking#1137](MirageNet/Mirage#1137)) ([c85d0df](MirageNet/Mirage@c85d0df))
* when modifying a prefab, Unity calls OnValidate for all scene objects based on that prefab, which caused Mirror to reset the sceneId because we only checked if a prefab is currently edited, not if THIS prefab is currently edited ([db99dd7](MirageNet/Mirage@db99dd7))
* **serialization:** Added NetworkWriter tests, found and fixed a bug in Write(Ray). ([MirrorNetworking#769](MirageNet/Mirage#769)) ([99c8f5c](MirageNet/Mirage@99c8f5c))
* **tests:** Added missing SyncListByteValid test file ([MirrorNetworking#634](MirageNet/Mirage#634)) ([b0af876](MirageNet/Mirage@b0af876))
* **weaver:** [MirrorNetworking#696](MirageNet/Mirage#696) detect .mystruct = new MyStruct() changes with syncvars ([MirrorNetworking#702](MirageNet/Mirage#702)) ([053949b](MirageNet/Mirage@053949b))
* **weaver:** fix [MirrorNetworking#706](MirageNet/Mirage#706) find system dlls ([MirrorNetworking#729](MirageNet/Mirage#729)) ([53be9b6](MirageNet/Mirage@53be9b6))
* **weaver:** fix [MirrorNetworking#796](MirageNet/Mirage#796), reload assemblies after initial import ([MirrorNetworking#1106](MirageNet/Mirage#1106)) ([d91b387](MirageNet/Mirage@d91b387))
* **websocket:** [MirrorNetworking#829](MirageNet/Mirage#829) fix InvalidOperationException with wss:// ([MirrorNetworking#830](MirageNet/Mirage#830)) ([2d682b5](MirageNet/Mirage@2d682b5))
* **websocket:** Remove send queues (they never worked) and SSL (temporarily) ([MirrorNetworking#879](MirageNet/Mirage#879)) ([3c60b08](MirageNet/Mirage@3c60b08))
* **websocket:** Use a buffer for most WS messages in WebGL client resulting in 0 alloc for most messages ([MirrorNetworking#848](MirageNet/Mirage#848)) ([8967a20](MirageNet/Mirage@8967a20))
* Telepathy updated to latest version: protect against allocation attacks via MaxMessageSize. Can be configured in the TelepathyTransport component now. ([67d715f](MirageNet/Mirage@67d715f))
* update NetworkIdentityEditor FindProperty to renamed variables ([a2cc14b](MirageNet/Mirage@a2cc14b))
* weaver Cmd/Rpc/Target prefix check is no longer trash ([MirrorNetworking#707](MirageNet/Mirage#707)) ([699a261](MirageNet/Mirage@699a261))
* workaround for [MirrorNetworking#791](MirageNet/Mirage#791) ([5c850aa](MirageNet/Mirage@5c850aa))

### Features

* [MirrorNetworking#869](MirageNet/Mirage#869) support structs in other assemblies ([MirrorNetworking#1022](MirageNet/Mirage#1022)) ([62d1887](MirageNet/Mirage@62d1887))
* Add roomPlayer parameter to OnRoomServerCreateGamePlayer ([MirrorNetworking#1317](https://github.com/MirrorNG/MirrorNG/issues/1317)) ([abf5cdc](MirageNet/Mirage@abf5cdc))
* Add SyncHashSet and SyncSortedSet ([MirrorNetworking#685](MirageNet/Mirage#685)) ([695979e](MirageNet/Mirage@695979e))
* Add Timeout to NetworkAuthenticator ([MirrorNetworking#1091](MirageNet/Mirage#1091)) ([e8cc9ba](MirageNet/Mirage@e8cc9ba))
* Add UPM configuration ([MirrorNetworking#11](MirageNet/Mirage#11)) ([9280af1](MirageNet/Mirage@9280af1))
* Add version to package file ([MirrorNetworking#1361](https://github.com/MirrorNG/MirrorNG/issues/1361)) ([e97ab93](MirageNet/Mirage@e97ab93))
* Add weaver support for Vector2Int and Vector3Int ([MirrorNetworking#646](MirageNet/Mirage#646)) ([e2a6ce9](MirageNet/Mirage@e2a6ce9))
* allow users to detect mirror version 3 ([ee9c737](MirageNet/Mirage@ee9c737))
* An authenticator that times out other authenticators ([MirrorNetworking#1211](https://github.com/MirrorNG/MirrorNG/issues/1211)) ([09f6892](MirageNet/Mirage@09f6892))
* Authentication Framework ([MirrorNetworking#1057](MirageNet/Mirage#1057)) ([56bcb02](MirageNet/Mirage@56bcb02))
* Chat example ([MirrorNetworking#1305](https://github.com/MirrorNG/MirrorNG/issues/1305)) ([9926472](MirageNet/Mirage@9926472))
* component based SyncToOwner, fixes [MirrorNetworking#39](MirageNet/Mirage#39) ([MirrorNetworking#1023](MirageNet/Mirage#1023)) ([c6d86b3](MirageNet/Mirage@c6d86b3))
* custom reader/writer via extension methods ([MirrorNetworking#1047](MirageNet/Mirage#1047)) ([b45afad](MirageNet/Mirage@b45afad))
* Custom readers and writers ([92b3e98](MirageNet/Mirage@92b3e98))
* fallback transport now supports uri ([MirrorNetworking#1296](https://github.com/MirrorNG/MirrorNG/issues/1296)) ([e4a701e](MirageNet/Mirage@e4a701e))
* generate serializers for IMessageBase structs ([MirrorNetworking#1353](https://github.com/MirrorNG/MirrorNG/issues/1353)) ([3c0bc28](MirageNet/Mirage@3c0bc28))
* Implement IReadOnlyList<T> in SyncLists ([MirrorNetworking#903](MirageNet/Mirage#903)) ([3eaaa77](MirageNet/Mirage@3eaaa77))
* Include version in release ([MirrorNetworking#1336](https://github.com/MirrorNG/MirrorNG/issues/1336)) ([e4f89cf](MirageNet/Mirage@e4f89cf))
* LLAPI transport can receive port from uri ([MirrorNetworking#1294](https://github.com/MirrorNG/MirrorNG/issues/1294)) ([7865a84](MirageNet/Mirage@7865a84))
* Mirror now supports message inheritance ([MirrorNetworking#1286](https://github.com/MirrorNG/MirrorNG/issues/1286)) ([f9d34d5](MirageNet/Mirage@f9d34d5))
* Multiplex based on url ([MirrorNetworking#1295](https://github.com/MirrorNG/MirrorNG/issues/1295)) ([c206f9a](MirageNet/Mirage@c206f9a))
* network writer pool to avoid expensive allocations ([3659acb](MirageNet/Mirage@3659acb))
* network writer pool to avoid expensive allocations ([MirrorNetworking#928](MirageNet/Mirage#928)) ([f5e9318](MirageNet/Mirage@f5e9318))
* NetworkConnection is optional for handlers ([MirrorNetworking#1202](https://github.com/MirrorNG/MirrorNG/issues/1202)) ([bf9eb61](MirageNet/Mirage@bf9eb61))
* new way to connect using uri ([MirrorNetworking#1279](https://github.com/MirrorNG/MirrorNG/issues/1279)) ([7c3622c](MirageNet/Mirage@7c3622c))
* Pass all information to spawn handler ([MirrorNetworking#1215](https://github.com/MirrorNG/MirrorNG/issues/1215)) ([d741bae](MirageNet/Mirage@d741bae))
* profiler info is available in production builds ([5649cc6](MirageNet/Mirage@5649cc6))
* Remove Command shortcut for host mode ([MirrorNetworking#1168](MirageNet/Mirage#1168)) ([94eda38](MirageNet/Mirage@94eda38))
* safer and consistent writers names ([MirrorNetworking#979](MirageNet/Mirage#979)) ([b4077c1](MirageNet/Mirage@b4077c1))
* Script Templates ([MirrorNetworking#1217](https://github.com/MirrorNG/MirrorNG/issues/1217)) ([8cf6a07](MirageNet/Mirage@8cf6a07))
* Secure messages that require authentication, fixes [MirrorNetworking#720](MirageNet/Mirage#720) ([MirrorNetworking#1089](MirageNet/Mirage#1089)) ([7ac43cd](MirageNet/Mirage@7ac43cd))
* Semantic release for UPM ([MirrorNetworking#24](MirageNet/Mirage#24)) ([8cbc005](MirageNet/Mirage@8cbc005))
* ship as a unitypackage ([11edc14](MirageNet/Mirage@11edc14))
* Show compile time error if overriding unused OnServerAddPlayer ([MirrorNetworking#682](MirageNet/Mirage#682)) ([a8599c1](MirageNet/Mirage@a8599c1))
* support sending and receiving ArraySegment<byte> ([MirrorNetworking#898](MirageNet/Mirage#898)) ([e5eecbf](MirageNet/Mirage@e5eecbf))
* support writing and reading array segments ([MirrorNetworking#918](MirageNet/Mirage#918)) ([f9ff443](MirageNet/Mirage@f9ff443))
* SyncDictionary can now be used for any IDictionary ([MirrorNetworking#703](MirageNet/Mirage#703)) ([2683572](MirageNet/Mirage@2683572))
* SyncList now supports any IList implementation ([MirrorNetworking#704](MirageNet/Mirage#704)) ([040bcb4](MirageNet/Mirage@040bcb4))
* SyncList.FindIndex added ([MirrorNetworking#823](MirageNet/Mirage#823)) ([b5ff43a](MirageNet/Mirage@b5ff43a))
* SyncSet custom Equality Comparer support ([MirrorNetworking#1147](MirageNet/Mirage#1147)) ([0f95185](MirageNet/Mirage@0f95185))
* SyncToOwner now works with authority ([MirrorNetworking#1204](https://github.com/MirrorNG/MirrorNG/issues/1204)) ([92d0df7](MirageNet/Mirage@92d0df7))
* telepathy can now receive port from uri ([MirrorNetworking#1284](https://github.com/MirrorNG/MirrorNG/issues/1284)) ([06946cf](MirageNet/Mirage@06946cf))
* Transport can send to multiple connections at once ([MirrorNetworking#1120](MirageNet/Mirage#1120)) ([bc7e116](MirageNet/Mirage@bc7e116))
* update upm package if tests pass ([MirrorNetworking#21](MirageNet/Mirage#21)) ([7447776](MirageNet/Mirage@7447776))
* user friendly weaver error ([MirrorNetworking#896](MirageNet/Mirage#896)) ([954a3d5](MirageNet/Mirage@954a3d5))
* Users may provide custom serializers for any type ([MirrorNetworking#1153](MirageNet/Mirage#1153)) ([9cb309e](MirageNet/Mirage@9cb309e))
* websocket can receive port in url ([MirrorNetworking#1287](https://github.com/MirrorNG/MirrorNG/issues/1287)) ([c8ad118](MirageNet/Mirage@c8ad118))
* Websockets now give client address, fix [MirrorNetworking#1121](MirageNet/Mirage#1121) ([MirrorNetworking#1125](MirageNet/Mirage#1125)) ([c9f317d](MirageNet/Mirage@c9f317d))
* **scene:** Add support for scene loading params ([MirrorNetworking#644](MirageNet/Mirage#644)) ([d48a375](MirageNet/Mirage@d48a375))
* **syncvar:** Add SyncDictionary ([MirrorNetworking#602](MirageNet/Mirage#602)) ([7d21bde](MirageNet/Mirage@7d21bde))
* **telepathy:** Split MaxMessageSize to allow setting a different value for client and server ([MirrorNetworking#749](MirageNet/Mirage#749)) ([f0a8b5d](MirageNet/Mirage@f0a8b5d))
* **websocket:** Re-enable native SSL ([MirrorNetworking#965](MirageNet/Mirage#965)) ([7ed4a9a](MirageNet/Mirage@7ed4a9a))

### Performance Improvements

* AddPlayerMessage is now a value type ([246a551](MirageNet/Mirage@246a551))
* allocation free enumerator for syncsets,  fixes [MirrorNetworking#1171](MirageNet/Mirage#1171) ([MirrorNetworking#1173](MirageNet/Mirage#1173)) ([035e630](MirageNet/Mirage@035e630))
* allocation free syncdict foreach, fix [MirrorNetworking#1172](MirageNet/Mirage#1172) ([MirrorNetworking#1174](MirageNet/Mirage#1174)) ([1ec8910](MirageNet/Mirage@1ec8910))
* avoid allocation for error messages ([c669ff1](MirageNet/Mirage@c669ff1))
* Avoid allocation when reading message payload ([MirrorNetworking#912](MirageNet/Mirage#912)) ([11750a9](MirageNet/Mirage@11750a9))
* avoid allocation with message structs ([MirrorNetworking#939](MirageNet/Mirage#939)) ([7c7c910](MirageNet/Mirage@7c7c910))
* avoid boxing for getting message id ([MirrorNetworking#1144](MirageNet/Mirage#1144)) ([9513842](MirageNet/Mirage@9513842))
* avoid boxing if there is no profiler ([a351879](MirageNet/Mirage@a351879))
* ClientAuthorityMessage is now a value type ([MirrorNetworking#991](MirageNet/Mirage#991)) ([d071438](MirageNet/Mirage@d071438))
* Custom IEnumerator for SyncLists to avoid allocations on foreach ([MirrorNetworking#904](MirageNet/Mirage#904)) ([4ffd5a2](MirageNet/Mirage@4ffd5a2))
* don't varint bytes and shorts ([4867415](MirageNet/Mirage@4867415))
* eliminate boxing with lists ([MirrorNetworking#901](MirageNet/Mirage#901)) ([8f6d4cb](MirageNet/Mirage@8f6d4cb))
* eliminate small allocation on remote calls ([MirrorNetworking#907](MirageNet/Mirage#907)) ([1c18743](MirageNet/Mirage@1c18743))
* eliminate string concat during remote method calls ([MirrorNetworking#908](MirageNet/Mirage#908)) ([70a532b](MirageNet/Mirage@70a532b))
* empty messages are value types now ([145edaa](MirageNet/Mirage@145edaa))
* messages should be value types ([MirrorNetworking#987](MirageNet/Mirage#987)) ([633fb19](MirageNet/Mirage@633fb19))
* MultiplexTransport: avoid Linq allocations that would happen on every packet send because Send calls .ServerActive() each time ([7fe8888](MirageNet/Mirage@7fe8888))
* Networkreader nonalloc ([MirrorNetworking#910](MirageNet/Mirage#910)) ([18f035d](MirageNet/Mirage@18f035d))
* objdestroy message is now a value type ([MirrorNetworking#993](MirageNet/Mirage#993)) ([a32c5a9](MirageNet/Mirage@a32c5a9))
* ObjHideMessage is now a value type ([MirrorNetworking#992](MirageNet/Mirage#992)) ([a49d938](MirageNet/Mirage@a49d938))
* OnDeserializeSafely without GC ([MirrorNetworking#804](MirageNet/Mirage#804)) ([27b7e25](MirageNet/Mirage@27b7e25))
* Optimize interest management ([f1ceb0c](MirageNet/Mirage@f1ceb0c))
* Optimize interest management ([MirrorNetworking#899](MirageNet/Mirage#899)) ([ff1a234](MirageNet/Mirage@ff1a234))
* Pack small 32 bit negatives efficiently ([480af1a](MirageNet/Mirage@480af1a))
* Pack small 64 bit negatives efficiently ([5f1ef4a](MirageNet/Mirage@5f1ef4a))
* Recycle argument writer to avoid allocations ([MirrorNetworking#945](MirageNet/Mirage#945)) ([9743216](MirageNet/Mirage@9743216))
* Reduce enum bandwidth ([MirrorNetworking#794](MirageNet/Mirage#794)) ([97e9ac2](MirageNet/Mirage@97e9ac2))
* remove allocations during syncvar sync ([MirrorNetworking#946](MirageNet/Mirage#946)) ([d2381ce](MirageNet/Mirage@d2381ce))
* remove BinaryWriter,  it allocates like crazy ([MirrorNetworking#929](MirageNet/Mirage#929)) ([7b3e82a](MirageNet/Mirage@7b3e82a))
* remove network transform allocation ([9e3ecc1](MirageNet/Mirage@9e3ecc1))
* remove syncvar boxing ([MirrorNetworking#927](MirageNet/Mirage#927)) ([b2ba589](MirageNet/Mirage@b2ba589))
* return the contents of the writer as an array segment ([MirrorNetworking#916](MirageNet/Mirage#916)) ([ced3690](MirageNet/Mirage@ced3690))
* reuse the network writer used for rpc parameters ([5dafc4d](MirageNet/Mirage@5dafc4d))
* rpc messages are now value types ([MirrorNetworking#997](MirageNet/Mirage#997)) ([b5b2f3e](MirageNet/Mirage@b5b2f3e))
* SceneMessage is now a value type ([MirrorNetworking#989](MirageNet/Mirage#989)) ([407b36a](MirageNet/Mirage@407b36a))
* spawn with client authority only takes 1 message ([MirrorNetworking#1206](https://github.com/MirrorNG/MirrorNG/issues/1206)) ([3b9414f](MirageNet/Mirage@3b9414f))
* SpawnPrefabMessage is now a value type ([a44efd1](MirageNet/Mirage@a44efd1))
* SpawnSceneObjectMessage is now a value type ([40c7d97](MirageNet/Mirage@40c7d97))
* Transports now give ArraySegment<byte> instead of byte[] (based on [MirrorNetworking#569](MirageNet/Mirage#569) and [MirrorNetworking#846](MirageNet/Mirage#846)) ([77bee45](MirageNet/Mirage@77bee45))
* update vars is now a value type ([MirrorNetworking#990](MirageNet/Mirage#990)) ([f99e71e](MirageNet/Mirage@f99e71e))
* Use 0 for null byte arrays ([MirrorNetworking#925](MirageNet/Mirage#925)) ([21ca49d](MirageNet/Mirage@21ca49d))
* use 0 for null strings ([MirrorNetworking#926](MirageNet/Mirage#926)) ([7181cd9](MirageNet/Mirage@7181cd9))
* use bitshift operations instead of division in varint ([fff765c](MirageNet/Mirage@fff765c))
* Use RemoveAt to remove elements from lists ([22b45f7](MirageNet/Mirage@22b45f7))
* use value types for empty messages ([MirrorNetworking#988](MirageNet/Mirage#988)) ([81d915e](MirageNet/Mirage@81d915e))
* Use WritePackedUInt32 in SyncList ([MirrorNetworking#688](MirageNet/Mirage#688)) ([2db7576](MirageNet/Mirage@2db7576))

* Merge pull request MirrorNetworking#650 from vis2k/networkclient_static_2 ([fac0542](MirageNet/Mirage@fac0542)), closes [MirrorNetworking#650](MirageNet/Mirage#650)

### BREAKING CHANGES

* Remove obsolete OnServerAddPlayer

Any person that overrides this method has a broken game.  These methods are never called anywhere.

The user gets a warning because they are overriding an obsolete method,  which might get ignored if they have lots of other warnings.   They would run their game and their game would not work at all.  No errors.

By removing these methods, users that override these methods will get a compile time error instead.  So they cannot ignore this error and they will fix it.

* Method is no longer available in NetworkLobbyManager
* Make NetworkClient Great Again!
@cani23 cani23 mentioned this issue Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulpach @SoftwareGuy @miwarnec