Fix blink not working orange pi zero 1

[ArendJan]

The check that checks "If not orangepizero1, then blink", is removed, blink works on the orange pi zero 1.

[ArendJan]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Analysis

• 🎯 Main theme: This PR is about fixing the blink functionality on the Orange Pi Zero 1.
• 📝 PR summary: The PR modifies the blink.sh script to fix the blinking issue on the Orange Pi Zero 1. The changes include removing a condition that checks for the existence of a variable "OPI", and adjusting the blinking sequence logic.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2
  The PR is relatively small and the changes are mostly about modifying the logic of the script. However, understanding the blinking sequence logic might require some time.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and the changes made are clear. However, it would be helpful to include a more detailed description in the PR explaining the issue and how the changes fix it. Also, it would be beneficial to add tests to verify the changes.

• 🤖 Code feedback:

  • relevant file: blink.sh
    suggestion: Consider using bash arithmetic instead of calling bc for simple arithmetic operations. This can improve the performance of the script. [medium]
    relevant line: FAST=$(echo "scale=2; $BLINK_SPEED/20" | bc)

  • relevant file: blink.sh
    suggestion: It's a good practice to use double brackets [[ ]] for condition checks in bash for more robust string handling. [medium]
    relevant line: if [ "${VALUE:i:1}" == "." ]; then

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[mklomp]

Looks good!