Add optional authentication for dashboard#37
Merged
Conversation
- Add PROXYMINI_AUTH_TOKEN config option - Protect /app/* and /api/logs with auth middleware when token is set - Add /login page with simple HTML form - Add /auth endpoint to validate token and set cookie - Redirect to /login when accessing protected routes without valid auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19
This PR adds optional authentication for the
/apppage and/api/logsendpoint.Changes
Configuration
PROXYMINI_AUTH_TOKENenvironment variable support ininternal/config/config.goAuthentication Flow
/login): Simple HTML form for entering the auth token/auth): POST endpoint that validates the token and sets an HttpOnly cookie/app/and/api/logsroutes whenPROXYMINI_AUTH_TOKENis setSecurity Features
Testing
go buildsucceedsgo test ./internal/proxy ./internal/requestlogPROXYMINI_AUTH_TOKEN- should work as beforePROXYMINI_AUTH_TOKEN=secret- should redirect to /loginCode Review Summary
Findings:
Security Checklist: