Fix #44: Add insecureTLSSkipVerify parameter to proxy config#45
Merged
Conversation
- Add insecureSkipVerify field to Proxy struct in config - Create custom HTTP client with TLS skip verify when enabled - Add test for insecureSkipVerify functionality - Update README with documentation for new parameter
- Add insecureClient field to ProxyHandler struct - Initialize insecure client in NewProxyHandler - Reuse client across requests instead of creating on each request - Resolves P2 performance issue from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #44
This PR adds support for skipping TLS certificate verification on a per-proxy basis through the new
insecureTLSSkipVerifyconfiguration parameter.Changes
insecureTLSSkipVerifyfield toProxystruct in configUse Case
When proxying to HTTPS targets with self-signed or invalid certificates (common in development/testing environments), users can now enable
insecureTLSSkipVerifyfor specific proxy routes instead of globally disabling TLS verification.Configuration Example
Testing
Code Review Summary
No P0 or P1 blockers found.
Findings
[P2] HTTP Client Creation on Every Request
http.Clientinstance on every request wheninsecureTLSSkipVerifyis true could impact performance under high load[P3] Missing Test for Default TLS Behavior
insecureTLSSkipVerifyis falseSecurity Considerations
The feature is intentionally insecure (as the name suggests) but acceptable because:
Known Limitations
Checklist