[DRAFT]feat: boost revise_paragraph_classification#52
Open
prnake wants to merge 1 commit intomiso-belica:mainfrom
Open
[DRAFT]feat: boost revise_paragraph_classification#52prnake wants to merge 1 commit intomiso-belica:mainfrom
prnake wants to merge 1 commit intomiso-belica:mainfrom
Conversation
Owner
|
Thank you for the changes. Can you write tests for these, please? It seems like a lot of code with quite a big impact. Also, it's 3 different changes so maybe we could split the smaller ones into PRs to merge them faster. |
Author
Sure, I’ll do these later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost a draft for discussion, including several changes:
Base on https://gist.github.com/prnake/e40fb3dd9b0af1f7a5fc73f2ee5236e9, it's much faster than original implementation with the same result, reduce time complexity from O(n^2) to O(n).