Skip to content

fix(ci): fix Chromatic CI not being skipped for dependency update branches#15766

Merged
syuilo merged 1 commit intomisskey-dev:developfrom
zyoshoka:fix-ci-to-skip-chromatic-for-deps-pr
Apr 7, 2025
Merged

fix(ci): fix Chromatic CI not being skipped for dependency update branches#15766
syuilo merged 1 commit intomisskey-dev:developfrom
zyoshoka:fix-ci-to-skip-chromatic-for-deps-pr

Conversation

@zyoshoka
Copy link
Member

@zyoshoka zyoshoka commented Apr 6, 2025

What

dependencies Pull requests that update a dependency file 系 PR で Chromatic CI が動いてしまっているのを修正します。branches-ignore は base ブランチをフィルタするので意味をなさず、if で弾く必要があります。

Why

Chromatic コスト削減

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@syuilo syuilo merged commit 1ede45c into misskey-dev:develop Apr 7, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Apr 7, 2025
@syuilo
Copy link
Member

syuilo commented Apr 7, 2025

🙏🏻

@zyoshoka zyoshoka deleted the fix-ci-to-skip-chromatic-for-deps-pr branch April 7, 2025 01:05
Mai-Shinano pushed a commit to SHINANOSKEY-Projekt/misskey that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants