fix(frontend): エラー画面で操作不能になることがあるのを修正#17533
Open
fruitriin wants to merge 4 commits into
Open
Conversation
dosubot
Bot
added
the
size:L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17533 +/- ##
===========================================
- Coverage 24.93% 15.21% -9.73%
===========================================
Files 1158 247 -911
Lines 39539 12360 -27179
Branches 11011 4196 -6815
===========================================
- Hits 9858 1880 -7978
+ Misses 23780 8203 -15577
+ Partials 5901 2277 -3624 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fruitriin
force-pushed
the
fix/error-page-unhandled
branch
from
287bbe8 to
3bbf156
Compare
kakkokari-gtyih
approved these changes
Jun 3, 2026
kakkokari-gtyih
changed the title
Member
|
エスケープ云々はスコープ外なので別にしても良い感 |
Member
|
#17273 はinertで画面が覆われることが原因だからエラーが循環参照するというのは別の問題かしら |
Member
|
エラーの循環参照は手元では発生したことがないから再現手順あると嬉しいわね |
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
Contributor
Author
|
#17532 再現手順の載ったIssueはこっちだった |
XSS対策のHTMLエスケープはこのPRの本来のスコープ (エラー画面の操作不能修正) 外の 変更だったため、別ブランチ (error-page-escape) に分離する。
Contributor
Author
|
@syuilo @kakkokari-gtyih |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
boot.js での renderError に突入したときのハンドリングをもうちょっとがんばる
Why
エラー画面で unhandled rejection が起きるとエラーが循環参照してUIスレッドをロックするから
fix #17532
Additional info (optional)
Checklist