fix(otel): don't setup TracerProvider, rely on application config #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK was creating its own TracerProvider when OTEL_EXPORTER_OTLP_ENDPOINT was set but no TracerProvider was configured. This caused issues when used in applications that configure their own TracerProvider: 1. The SDK's TracerProvider would be set first, preventing the app's setup 2. The endpoint was passed without /v1/traces path, causing 404 errors Now the SDK follows OTEL best practices: - Libraries/SDKs get tracers from the global provider - Applications configure the TracerProvider - If no provider is set, tracing is effectively disabled (NoOp) This allows applications to control when and how OTEL is configured, and the SDK will automatically use whatever TracerProvider is available. Removed: - QuietOTLPSpanExporter class (no longer needed) - OTEL_EXPORTER_OTLP_* constants (no longer used) - TracerProvider setup logic
jean-malo
approved these changes
Jan 6, 2026
aac228
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK was creating its own TracerProvider when OTEL_EXPORTER_OTLP_ENDPOINT was set but no TracerProvider was configured. This caused issues when used in applications that configure their own TracerProvider:
Now the SDK follows OTEL best practices:
This allows applications to control when and how OTEL is configured, and the SDK will automatically use whatever TracerProvider is available.
Removed: