Merged
Conversation
Contributor
Author
|
@EmmaBouhanna added you for already a first quick look |
paulcacheux
reviewed
Apr 23, 2026
| else: | ||
| # Stream exhausted without a terminal event — retry. | ||
| continue | ||
| # Terminal event received. |
There was a problem hiding this comment.
do we need this ? since you returned already line 200
| ) | ||
| from .utils import response_format_from_pydantic_model | ||
| from .utils.response_format import CustomPydanticModel | ||
| from .workflows import ( |
There was a problem hiding this comment.
this feels like a bad idea, let's keep everything in extra.workflows no ?
There was a problem hiding this comment.
what about this, isn't it strange that we export nothing from workflows except those ?
Contributor
Author
There was a problem hiding this comment.
Yes agreed. removing it!
paulcacheux
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.