-
Notifications
You must be signed in to change notification settings - Fork 2
Switch routing policies fix #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the ordering and requirements for routing policy terms in the OpenAPI specification. The changes ensure alphabetical ordering of enum values and add a required name field to switch routing policy terms.
Key changes:
- Alphabetized the
gw_routing_policy_term_matching_protocol_enumvalues to match standard enum ordering conventions - Added
nameas a required field forsw_routing_policy_termschema
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| workdir/openapi.yaml | Updated enum ordering and added required name field to switch routing policy term schema |
| mist.openapi.yaml | Applied identical changes as workdir/openapi.yaml to maintain consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmunzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- getSiteInsightMetricsForGateway - getSiteInsightMetricsForMxEdge - getSiteInsightMetricsForSwitch
remove useless `site_id` query parameter
wprins-JNPR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.