Utreexo flatfile improvements #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the behavior of the function to be more random in how the slices are generated.
Pull Request Test Coverage Report for Build 1272787779
💛 - Coveralls |
Changes the function to only write once to the data file per once call of StoreData(). Before, magic bytes, the size of the data, and data would all be separate calls to the disk. Now they're made into a single byte slice with the data file being accessed only once per StoreData().
kcalvinalvin
force-pushed
the
utreexo-flatfile-improvements
branch
from
377d508 to
152a302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 things done:
1: Better random byte slices for flatfile testing. Now slices generated for test are more diverse in length.
2: Less calls to disk for StoreData(). Previously, there would be 3 separate calls to the data file. Now, there's only one.