Upgrading graphin to v3#14
Merged
Merged
Conversation
Collaborator
GabrielAppleby
commented
Feb 14, 2025
GabrielAppleby
commented
- A lot of type changes
- A lot of type changes
GabrielAppleby
commented
Feb 14, 2025
| "dependencies": { | ||
| "@antv/graphin": "^2.7.27", | ||
| "@antv/graphin-components": "^2.4.1", | ||
| "@antv/graphin": "^3.0.4", |
Collaborator
Author
There was a problem hiding this comment.
Graphin-components seems to be abandoned. A lot of the functionality is built into g6 now.
GabrielAppleby
commented
Feb 14, 2025
|
|
||
| //create the edges for the graph | ||
| const edges = Utils.processEdges(triples.map(triple => ( | ||
| const edges = triples.map(triple => ( |
Collaborator
Author
There was a problem hiding this comment.
Utils.processEdges no longer exists. It was used to properly style edges for self-loops and multiple edges between nodes. I think I originally included it for a very early version of the results graph that ended up being too messy.
I don't think either scenario should happen with the query graph visualization, so I think we are fine to just remove it. Let me know if there is an edge case I'm not thinking about @harryli0088 .
(If needed I can just copy over the function from the previous version of graphin as it is self-contained.)
harryli0088
approved these changes
Feb 14, 2025
harryli0088
added a commit
that referenced
this pull request
May 29, 2025
* making progress on state diagram * state diagram draft working state * progress on making a graph vis of the results * added tabs feature for results, cleaned up results graph algo and comments * results and history now contains queryValue, so that the value in the editor is separate from the history * progress on main stages and sub stages * clamp chat status badge messages that are too long * Upgrading graphin to v3 (#14) - A lot of type changes * simplified LinkQ stages * updated node and rank sep * Added react tables to resultsgraph. * fixed ref type issue * Disallow text highlighting in results graph tables, change selection color to blue in said tables. * center query graph on data change, tables in results graph have white background * Added keybindings for rerender and prevent drag to results graph. * Adding fitView to toolbars, and double rendering the results graph. * Adding Table Title. * Reformatting TableNode. * tables in results graph render cells like results table * only show label column if data is present, fitView after graph is done rendering, legends in top-right * query graph legend in top-right * Scrolls to row on click in results graph. * first attempt at adding chain of thought to filter entities * added filtering conversation forproperties and tail search * refactored how we are interacting with redux * fixed missing initial system message * fixed LinkQ stages bugs * make filtering toggleable from the code * fixed name bug * auto scroll on query results * catch KG API errors * stages uses blue color scheme, added SPARQL parsing line * fixed type error with substage rename, set model version in one location * fixed npm vulnerabilities --------- Co-authored-by: Harry Li <harry.li@ll.mit.edu> Co-authored-by: GabrielAppleby <Gabriel.appleby@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.