This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Merged
Conversation
- Add new optional notarize section to the config - Allow specifying notarize in lieu of sources
Contributor
|
Thanks for pulling in these changes with your improvements. I may put up another PR for the Entitlements enhancement. (Let me know if you'd prefer I use GitHub Issues for enhancement-related things, or if "drive-by PRs" are OK) |
Owner
Author
|
Awesome. It’d be helpful if you just opened an issue to warn me its coming so I don’t overlap with you. That cool? If you want to include some thoughts on how you’re going to do the config we can bikeshed on that there so when the PR comes in hopefully can just merge quickly. I appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1
@etter-tanium - Here is what I noted in my comment. I added commits to your branch so you retain original authorship there.