Skip to content

fetch discussion comment URL#73

Merged
mitchellh merged 1 commit intomitchellh:mainfrom
trag1c:discussion-comment-id
Feb 23, 2026
Merged

fetch discussion comment URL#73
mitchellh merged 1 commit intomitchellh:mainfrom
trag1c:discussion-comment-id

Conversation

@trag1c
Copy link
Contributor

@trag1c trag1c commented Feb 22, 2026

Closes #71

Irrelevant for the current state of the PR (so feel free to ignore this entire PR description), but in my issue I said this:

I had to deal with this in the past (for Ghostty bot actually lol) so I have a fix ready!

What I had to deal with was getting the node ID (DC_bO8RxDkUrw4=) from the comment ID present in URLs by manually constructing it. But since we already have the node ID, we can just request the entire comment URL… so yeah, I wasted like 30 minutes on making an explainer diagram for my original solution before realizing it's much simpler 🥲

I don't want it to go to waste, so I'm including it here for fun. Actually -- would it be useful to allow the URL comment ID to be passed into gh-manage-by-discussion rather than the GraphQL node ID?

@mitchellh
Copy link
Owner

Thanks, beautiful image haha.

I don't want it to go to waste, so I'm including it here for fun. Actually -- would it be useful to allow the URL comment ID to be passed into gh-manage-by-discussion rather than the GraphQL node ID?

Maybe so! I don't think its super critical because of how we call it but its nice.

@mitchellh mitchellh merged commit fb8e27b into mitchellh:main Feb 23, 2026
4 checks passed
@trag1c trag1c deleted the discussion-comment-id branch February 23, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include discussion comment URL

2 participants