Skip to content

Comments

Fix all current pre-patch errors for Midnight 12.0.0#9

Merged
mitchnull merged 2 commits intomitchnull:masterfrom
Hinos:master
Feb 7, 2026
Merged

Fix all current pre-patch errors for Midnight 12.0.0#9
mitchnull merged 2 commits intomitchnull:masterfrom
Hinos:master

Conversation

@Hinos
Copy link
Contributor

@Hinos Hinos commented Feb 7, 2026

  1. Prevent secret value errors
  2. Restore display values for target
  • Handles value requests in a function to prevent/handle errors if the request returns a secret value.
  • Displays range even if a secret value was returned, while preventing errors.
  • Works in dungeons as well as outside! Tested all.
  • No visual cues of fps drops or other performance issues related to this change.

Issues this closes:

  • #39, #38 -- On CurseForge
  • and all of comments on curse too, because they didn't submit issues neither on github or curse

I'm not a pro at lua so please do more testing on your end. Just wanted to help. So far it works on my end and there are no errors. Hope it helps!

Cheers!

Hinos added 2 commits February 7, 2026 14:51
This fix resolves all current pre-patch errors (Midnight 12.0.0).
- Handles value requests in a function to prevent errors if it returns  secret values
- Displays range even if a secret value was returned
- Works in dungeons as well as outside! Tested all.
@mitchnull mitchnull merged commit 470f2d3 into mitchnull:master Feb 7, 2026
@mitchnull
Copy link
Owner

Thanks! Unfortunately I can't test it now, so I'm hoping it works as advertised :)

@Hinos
Copy link
Contributor Author

Hinos commented Feb 7, 2026

Alright. Thanks. If I get any further errors I'll see what I can do and submit another PR or post a comment again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants