Added switch to dis/allow rotation of boxes within the bin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ruby checks for travis-ci have passed, I did not want to bump/drop the rbx-2 tests without first checking with the repo owner |
Member
|
@sam-wan looks good, let's drop rbx-2. |
Contributor
Author
|
@ebeigarts , |
Member
|
Thanks! Released in v0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Implementation of Bin packing algorithm is good, however we have added restriction to not allow rotation of boxes.
HOW
update rspec tests to verify the base packer heuristic does not rotate boxes.