Merged
Conversation
niklavsBariss
force-pushed
the
visual-configs
branch
from
5579c82 to
2e24263
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
janisievins
approved these changes
Dec 18, 2025
niklavsBariss
force-pushed
the
visual-configs
branch
from
5925dad to
8d372ef
Compare
Comment on lines
984
to
992
| .style('color', getDatasetColor(dataset)) | ||
| .html(props.noDataString) | ||
|
|
||
| if (props.hasHighlightListener) { | ||
| highlightValues.push(null) | ||
| } | ||
| return | ||
| } | ||
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
niklavsBariss
force-pushed
the
develop
branch
from
95f9b41 to
0bf5576
Compare
This reverts commit 1943672.
niklavsBariss
force-pushed
the
visual-configs
branch
from
8d372ef to
9bf239c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements multiple props for configurating chart visually:
xDividerConfig, highlightPosition, highlightValuePositionBelow is a demo:
https://github.com/user-attachments/assets/cd1ef2a7-b74a-4bd5-92f0-2cfb05680751