Merged
Conversation
janisievins
approved these changes
Oct 8, 2025
Collaborator
janisievins
left a comment
janisievins
left a comment
There was a problem hiding this comment.
LGTM. Pāris ieteikumi/komentāri no malas
Comment on lines
+136
to
+149
| function getDatasetColor(dataset, value) { | ||
| if (dataset.color.type === 'thresholds') { | ||
| const crossedThreshold = dataset.color.thresholds.find( | ||
| (threshold) => value >= threshold.value | ||
| ) | ||
|
|
||
| if (crossedThreshold) { | ||
| return crossedThreshold.color | ||
| } | ||
|
|
||
| return dataset.color.baseColor | ||
| } | ||
| return dataset.color | ||
| } |
Collaborator
There was a problem hiding this comment.
Ja pareizi saprotu, dataset.color.type šobrīd var būt undefined vai 'thresholds'? Varētu būt vēl kaut kas uz nākotni? Domāju, varbūt switch labāk izmantot un katru case tad var nokomentēt/nodokumentēt.
Member
Author
There was a problem hiding this comment.
export type Dataset = {
measurementName: string
color:
| string
| {
type: 'thresholds'
baseColor: string
/**
* Must be sorted by value descending (highest value first)
*/
thresholds: { value: number; color: string }[]
/**
* Gradient transition distance around thresholds.
* Must be non-negative. Should be less than half the distance between thresholds.
* @default 0 - no blur
*/
gradientBlur?: number
}
Šobrīd nav paredzēti citi tipi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I've added support for thresholds and multi-color-gradient
Screen_recording_20251006_084549.mp4
Video also contains area gradient behaviour with negative values. Have to decide what to do with that