Fix simulate init value for unfailed components#161
Open
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Open
Fix simulate init value for unfailed components#161Chessing234 wants to merge 1 commit intomitmath:Fall24from
Chessing234 wants to merge 1 commit intomitmath:Fall24from
Conversation
…onents Components that never fail (small p) were recorded as failing at time 0 instead of never failing. Initialize the failure-time array with max_steps and check against max_steps in the loop, so unfailed components correctly report max_steps as their failure time. Fixes mitmath#154 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulatefunction insimulating_component_failure.jlto initialize the failure-time array withmax_stepsinstead of0p) now correctly reportmax_stepsas their failure time instead of0max_stepsparameter (default100) to replace the hardcoded value, and update all loop conditions to compare againstmax_stepsFixes #154
Test plan
pvalues (e.g.p = 0.001) and verify unfailed components showmax_steps(100) instead of 0p = 1.0and verify all components still fail at time 1pvalues🤖 Generated with Claude Code