Skip to content

Add vendored files to manifest template#39

Merged
mhils merged 1 commit intomitmproxy:mainfrom
injust:main
Dec 11, 2024
Merged

Add vendored files to manifest template#39
mhils merged 1 commit intomitmproxy:mainfrom
injust:main

Conversation

@injust
Copy link
Copy Markdown
Contributor

@injust injust commented Dec 8, 2024

This allows you to install with

pip install git+https://github.com/mitmproxy/android-unpinner.git

which is probably better than the current method of cloning and installing in editable mode.

My use case for this is installing android-unpinner as a dev dependency in another project.

I only tested the patch-apks command locally.

@mhils
Copy link
Copy Markdown
Member

mhils commented Dec 10, 2024

Thanks! Happy to add the manifest file, but I do prefer the editable install as it's easier to tinker with.

@injust
Copy link
Copy Markdown
Contributor Author

injust commented Dec 11, 2024

Makes sense, I removed the README edit.

Copy link
Copy Markdown
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mhils mhils merged commit ca44ede into mitmproxy:main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants