Is UpstreamConnectLayer deprecated ?!

[mrsiano]

hi,
we've upgraded our mitm project and we can't import the following module:
from mitmproxy.proxy.layers.http import UpstreamConnectLayer

[mhils]

Yes, mitmproxy 7 has a completely new proxy core: https://mitmproxy.org/posts/releases/mitmproxy7/

[mrsiano]

first of all thanks,
the context is that we're trying to have ntlm authentication

[mrsiano]

using proxy on top of it

[mhils]

I don't know how NTLM authentication works, but if it does not require additional roundtrips modifying https://github.com/mitmproxy/mitmproxy/blob/main/mitmproxy/addons/upstream_auth.py should be good enough. Happy to accept a PR! Had you bothered to send one for the old proxy core, chances would be non-negligible that I would have ported it over. 😉

[mrsiano]

Thanks, so actually we need to keep using the same TCP connection for the nltm authentication session
thats why we write the file previously

    assembled_request = http1.assemble_request(flow.request)
    flow.server_conn.write(assembled_request)
    flow.server_conn.wfile.flush()
    http1.read(
            rfile=flow.server_conn.rfile,
            request=flow.request,
            body_size_limit=body_size_limit

can you think of any idea who we can use ntlm authenticaion with UpstreamProxy ?

[mhils]

I don't know how NTLM authentication works, so I can't really comment on this.

[mrsiano]

hi @mhils there is a way to evaluate another request on the same flow.server_conn of flow: http.HTTPFlow object ?

[mrsiano]

or another option is to get the http session() reference

[mrsiano]

@mhils ping