fix #6426 - Optimize LDAP Proxy Auth#6428
Merged
mhils merged 5 commits intomitmproxy:mainfrom Oct 31, 2023
Merged
Conversation
mhils
reviewed
Oct 30, 2023
| "any" to accept any user/pass combination, | ||
| "@path" to use an Apache htpasswd file, | ||
| or "ldap[s]:url_server_ldap[:port]:dn_auth:password:dn_subtree" for LDAP authentication. | ||
| or "ldap[s]:url_server_ldap:port:dn_auth:password:dn_subtree:ldap_search_filter_key" for LDAP authentication. |
Member
There was a problem hiding this comment.
This breaks backward-compatibility for existing users. Can we add a separate proxyauth_ldap_filter_key option maybe? I guess alternatively we could add a ?search_filter_key=... suffix, but not sure if that's any better.
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your suggestion. I have recommitted.
mhils
approved these changes
Oct 31, 2023
Member
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
Awesome, thanks! Can you please add a CHANGELOG entry? This is good to go otherwise. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6426
Description
When I used ldap as a proxy authentication method, I found that the filter key was hardcoded, so I made it possible to pass in this item.
Checklist