Conversation
|
if you like it, I can then update the tests. Let me know :) thank you |
|
@mhils I made a change in the this is the change:
|
app.css is autogenerated from the less files. So you want to modify the less files in https://github.com/mitmproxy/mitmproxy/tree/main/web/src/css and keep app.css as-is. It will be automatically updated on the next release. :) |
ahhh I see now, thank you ! |
lups2000
force-pushed
the
feature/comments-webUI
branch
from
c2eeb78 to
ba05efb
Compare
|
@mhils Is there a reason why the folder |
|
a) looks like we can remove the editors exclusion. |
Okay thank you very much! |
mhils
left a comment
mhils
left a comment
There was a problem hiding this comment.
Looks good, thanks!
The more I look at it the more I want to merge it with the Timings pane, but let's resist the urge and get this in first. :)
| it("should be possible to get a comment", () => { | ||
| let tflow = TFlow(); | ||
| expect(tflow.comment).toEqual("I'm a comment!"); | ||
| }); |
Alright :) I'll do it in the future, I promise ahah. For the coverage ? Is it fine ? |
2 participants
Description
Added the possibility to add a comment as a column in the flow table. Then, added a section in the flow details panel where we can see and modify the comment. I modified the backend as well since we were not supporting the modification of a comment. I hope the way I did it is correct :)
closes : #6708
Checklist