This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Conversation
carsongee
force-pushed
the
feature/skeleton
branch
3 times, most recently
from
05749ad to
956b15f
Compare
carsongee
force-pushed
the
feature/skeleton
branch
from
956b15f to
efd0cd1
Compare
Contributor
Author
|
I went ahead and added the flask application structure while I was waiting. Still no functional code, just design that is open to critique |
Contributor
Author
There was a problem hiding this comment.
yeah, when I write code to handle the post, I'll add that method, planning on using WTForm to validate the edx post and on the get provide a user interface to exercise the form similar to how it is now, but spruced up a bit.
carsongee
force-pushed
the
feature/skeleton
branch
2 times, most recently
from
88d4d66 to
ac5fe6d
Compare
|
Changes Unknown when pulling ac5fe6d1f8eadeff70672565fc68cffee8bc4adc on feature/skeleton into * on master*. |
lmod_proxy/edx_grades/__init__.py
Outdated
Contributor
There was a problem hiding this comment.
nit: "Blueprint" is one word
Contributor
Author
There was a problem hiding this comment.
good catch, thanks.
carsongee
force-pushed
the
feature/skeleton
branch
from
ac5fe6d to
57d0660
Compare
|
Changes Unknown when pulling 57d0660 on feature/skeleton into * on master*. |
pwilkins
added a commit
that referenced
this pull request
Mar 17, 2015
Initial project structure - This all looks good to me. I'm interested in the use of Blueprints to generalize edX patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the base folder/file structure of the project. Need review quickly to continue work.
This will close #3